From 01ff1a36fd40199505d816752f09151256a75739 Mon Sep 17 00:00:00 2001 From: mar Date: Thu, 18 Feb 2016 19:47:38 +0000 Subject: [PATCH] Use object lookup instead of long RegExp Should be faster. --- mithril.js | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/mithril.js b/mithril.js index e30f9cae..01896d7c 100644 --- a/mithril.js +++ b/mithril.js @@ -38,9 +38,24 @@ function noop() {} - /* eslint-disable max-len */ - var voidElements = /^(AREA|BASE|BR|COL|COMMAND|EMBED|HR|IMG|INPUT|KEYGEN|LINK|META|PARAM|SOURCE|TRACK|WBR)$/ - /* eslint-enable max-len */ + var voidElements = { + AREA: 1, + BASE: 1, + BR: 1, + COL: 1, + COMMAND: 1, + EMBED: 1, + HR: 1, + IMG: 1, + INPUT: 1, + KEYGEN: 1, + LINK: 1, + META: 1, + PARAM: 1, + SOURCE: 1, + TRACK: 1, + WBR: 1 + } // caching commonly used variables var $document, $location, $requestAnimationFrame, $cancelAnimationFrame @@ -454,7 +469,7 @@ nodes = injectHTML(parentElement, index, data) } else { nodes = [$document.createTextNode(data)] - if (!voidElements.test(parentElement.nodeName)) { + if (!(parentElement.nodeName in voidElements)) { insertNode(parentElement, nodes[0], index) } }