vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix m.version to not depend on package.json (#2464)

Browse source 
* Fix `m.version` to not depend on `package.json`

Created an accidental breaking change.

* Update changelog

* Fix a failing test
This commit is contained in:
Isiah Meadows 2019-07-09 19:26:00 -04:00 • committed by GitHub
parent 1f4b2cf49a
commit 1434ba313f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 13 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
bundler/bundle.js
View file

@ -24,10 +24,6 @@ module.exports = function (input) {
var include = /(?:((?:var|let|const|,|)[\t ]*)([\w_$\.\[\]"'`]+)(\s*=\s*))?require\(([^\)]+)\)(\s*[`\.\(\[])?/gm
var uuid = 0
var process = function(filepath, data) {
// HACK: inline Mithril's `package.json` keys without reading the whole file.
data = data.replace(/require\((['"])\.\/package\.json\1\)\.(\w+)/, function (match, quote, key) {
return JSON.stringify(pkg[key])
})
data.replace(declaration, function(match, binding) {bindings[binding] = 0})
return data.replace(include, function(match, def, variable, eq, dep, rest) {

7
bundler/tests/test-bundler.js
View file

@ -320,11 +320,4 @@ o.spec("bundler", function() {
remove("a.js")
remove("b.js")
})
o("reads package.json keys", function() {
write("a.js", 'var b = require("./package.json").version')
o(bundle(ns + "a.js")).equals(";(function() {\nvar b = " + JSON.stringify(pkg.version) + "\n}());")
remove("a.js")
})
})