vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add docs in setAttributes

Browse source
This commit is contained in:
Leo Horie 2014-09-21 14:49:00 -04:00
parent 57e9e1557e
commit 16faf2159d
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
mithril.js
View file

@ -275,13 +275,17 @@ Mithril = m = new function app(window, undefined) {
for (var attrName in dataAttrs) { for (var attrName in dataAttrs) {
var dataAttr = dataAttrs[attrName] var dataAttr = dataAttrs[attrName]
var cachedAttr = cachedAttrs[attrName] var cachedAttr = cachedAttrs[attrName]
//see #29 for the reason behind `activeElement` usage
if (!(attrName in cachedAttrs) || (cachedAttr !== dataAttr) || node === window.document.activeElement) { if (!(attrName in cachedAttrs) || (cachedAttr !== dataAttr) || node === window.document.activeElement) {
cachedAttrs[attrName] = dataAttr cachedAttrs[attrName] = dataAttr
try { try {
//`config` isn't a real attributes, so ignore it
if (attrName === "config") continue if (attrName === "config") continue
//hook event handlers to the auto-redrawing system
else if (typeof dataAttr == "function" && attrName.indexOf("on") == 0) { else if (typeof dataAttr == "function" && attrName.indexOf("on") == 0) {
node[attrName] = autoredraw(dataAttr, node) node[attrName] = autoredraw(dataAttr, node)
} }
//handle `style: {...}`
else if (attrName === "style" && typeof dataAttr == "object") { else if (attrName === "style" && typeof dataAttr == "object") {
for (var rule in dataAttr) { for (var rule in dataAttr) {
if (cachedAttr == null || cachedAttr[rule] !== dataAttr[rule]) node.style[rule] = dataAttr[rule] if (cachedAttr == null || cachedAttr[rule] !== dataAttr[rule]) node.style[rule] = dataAttr[rule]
@ -290,14 +294,19 @@ Mithril = m = new function app(window, undefined) {
if (!(rule in dataAttr)) node.style[rule] = "" if (!(rule in dataAttr)) node.style[rule] = ""
} }
} }
//handle SVG
else if (namespace != null) { else if (namespace != null) {
if (attrName === "href") node.setAttributeNS("http://www.w3.org/1999/xlink", "href", dataAttr) if (attrName === "href") node.setAttributeNS("http://www.w3.org/1999/xlink", "href", dataAttr)
else if (attrName === "className") node.setAttribute("class", dataAttr) else if (attrName === "className") node.setAttribute("class", dataAttr)
else node.setAttribute(attrName, dataAttr) else node.setAttribute(attrName, dataAttr)
} }
//part of fix for #29
else if (attrName === "value" && tag === "input") { else if (attrName === "value" && tag === "input") {
if (node.value !== dataAttr) node.value = dataAttr if (node.value !== dataAttr) node.value = dataAttr
} }
//handle cases that are properties (but ignore cases where we should use setAttribute instead)
//- list and form are typically used as strings, but are DOM element references in js
//- when using CSS selectors (e.g. `m("[style='']")`), style is used as a string, but it's an object in js
else if (attrName in node && !(attrName == "list" || attrName == "style" || attrName == "form")) { else if (attrName in node && !(attrName == "list" || attrName == "style" || attrName == "form")) {
node[attrName] = dataAttr node[attrName] = dataAttr
} }