From 195263d226293838fc2c9263ceea5162cc26a891 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Gerardy Date: Mon, 29 May 2017 13:59:31 +0200 Subject: [PATCH] [test-utils/domMock] restore Attr.nodeValue for backwards compatibility --- test-utils/domMock.js | 4 ++++ test-utils/tests/test-domMock.js | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/test-utils/domMock.js b/test-utils/domMock.js index 4726a127..ad0c669d 100644 --- a/test-utils/domMock.js +++ b/test-utils/domMock.js @@ -111,6 +111,10 @@ module.exports = function(options) { nodeValue = "" + value /*eslint-enable no-implicit-coercion*/ }, + get nodeValue() {return nodeValue}, + set nodeValue(value) { + this.value = value + } } } function setAttributeNS(ns, name, value) { diff --git a/test-utils/tests/test-domMock.js b/test-utils/tests/test-domMock.js index a71d8e8e..e56b3c04 100644 --- a/test-utils/tests/test-domMock.js +++ b/test-utils/tests/test-domMock.js @@ -349,6 +349,7 @@ o.spec("domMock", function() { div.setAttribute("id", "aaa") o(div.attributes["id"].value).equals("aaa") + o(div.attributes["id"].nodeValue).equals("aaa") o(div.attributes["id"].namespaceURI).equals(null) }) o("works w/ number", function() { @@ -381,6 +382,10 @@ o.spec("domMock", function() { div.attributes["id"].value = 123 o(div.attributes["id"].value).equals("123") + + div.attributes["id"].nodeValue = 456 + + o(div.attributes["id"].value).equals("456") }) }) o.spec("hasAttribute", function() {