vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow xlink:href to get removed, fix option.value in mock

Browse source
This commit is contained in:
Isiah Meadows 2017-10-01 19:26:43 -04:00
parent e36a8db9d4
commit 348bed0a7e
6 changed files with 30 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test-utils/domMock.js
View file

@ -445,7 +445,7 @@ module.exports = function(options) {
if (element.nodeName === "OPTION") {
var valueSetter = spy(function(value) {
/*eslint-disable no-implicit-coercion*/
this.setAttribute("value", value === null ? "" : "" + value)
this.setAttribute("value", "" + value)
/*eslint-enable no-implicit-coercion*/
})
Object.defineProperty(element, "value", {

4
test-utils/tests/test-domMock.js
View file

@ -954,11 +954,11 @@ o.spec("domMock", function() {
o(select.selectedIndex).equals(1)
}
})
o("option.value = null is converted to the empty string", function() {
o("option.value = null is converted to 'null'", function() {
var option = $document.createElement("option")
option.value = null
o(option.value).equals("")
o(option.value).equals("null")
})
o("setting valid value works with optgroup", function() {
var select = $document.createElement("select")