vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clean up duplicate test

Browse source
This commit is contained in:
Leo Horie 2016-08-18 00:01:11 -04:00
parent 29ee36e967
commit 3682a78880
2 changed files with 18 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

30
render/tests/test-onbeforeremove.js
View file

@ -36,7 +36,7 @@ o.spec("onbeforeremove", function() {
}) })
o("calls onbeforeremove when removing element", function(done) { o("calls onbeforeremove when removing element", function(done) {
var vnode = {tag: "div", attrs: { var vnode = {tag: "div", attrs: {
oninit: function(){vnode.state = {}}, oninit: function() {vnode.state = {}},
onbeforeremove: remove onbeforeremove: remove
}} }}
@ -190,31 +190,37 @@ o.spec("onbeforeremove", function() {
}) })
o("finalizes the remove phase only once when `done()` is called synchronously from both attrs- and tag.onbeforeremove", function() { o("finalizes the remove phase only once when `done()` is called synchronously from both attrs- and tag.onbeforeremove", function() {
var onremove = o.spy() var onremove = o.spy()
var onbeforeremove = function(vnode, done){done()}
var component = { var component = {
view: function(){return {tag:'br'}}, onbeforeremove: onbeforeremove,
onbeforeremove: function(vnode, done){done()}, onremove: onremove,
onremove: onremove view: function() {},
} }
render(root, [{tag: component, attrs: component}]) render(root, [{tag: component, attrs: {onbeforeremove: onbeforeremove, onremove: onremove}}])
render(root, []) render(root, [])
o(onremove.callCount).equals(2) // once for `tag`, once for `attrs` o(onremove.callCount).equals(2) // once for `tag`, once for `attrs`
}) })
o("doesn't finalize prematurely if `done` is called twice in the `tag` hook", function(done) { o("doesn't finalize prematurely if `done` is called twice in the `tag` hook", function(done) {
var async = false var async = false
var component = { var component = {
view: function(){return {tag:'br'}}, view: function() {},
onbeforeremove: function(vnode, doneRemoving){ onbeforeremove: function(vnode, doneRemoving){
doneRemoving() doneRemoving()
doneRemoving() doneRemoving()
}, },
onremove: function(){ onremove: function() {
o(async).equals(true)("onremove should be called asynchronously") o(async).equals(true)
done() done()
} },
} }
render(root, [{tag:component, attrs: {onbeforeremove: function(vnode, doneRemoving){ render(root, [{
callAsync(doneRemoving) tag:component,
}}}]) attrs: {
onbeforeremove: function(vnode, doneRemoving){
callAsync(doneRemoving)
}
}
}])
render(root, []) render(root, [])
async = true async = true
}) })

11
render/tests/test-onremove.js
View file

@ -145,15 +145,4 @@ o.spec("onremove", function() {
o(vnode.dom).notEquals(updated.dom) o(vnode.dom).notEquals(updated.dom)
}) })
o("The remove phase is finalized only once when `done()` is called synchronously from both attrs- and tag.onbeforeremove", function () {
var onremove = o.spy()
var component = {
view: function(){return m('br')},
onbeforeremove: function(vnode, done){done()},
onremove: onremove
}
render(root, [{tag: component, attrs: component}])
render(root, [])
o(onremove.callCount).equals(2)
})
}) })