vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1244 from pygy/robust-onbeforeremove

Browse source 
Robust onbeforeremove
This commit is contained in:
Leo Horie 2016-08-17 23:54:36 -04:00 • committed by GitHub
commit 3761226c2c
3 changed files with 78 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

30
render/tests/test-onbeforeremove.js
View file

@ -188,4 +188,34 @@ o.spec("onbeforeremove", function() {
o(root.childNodes.length).equals(1)
o(root.firstChild.firstChild.nodeValue).equals("2")
})
o("finalizes the remove phase only once when `done()` is called synchronously from both attrs- and tag.onbeforeremove", function() {
var onremove = o.spy()
var component = {
view: function(){return {tag:'br'}},
onbeforeremove: function(vnode, done){done()},
onremove: onremove
}
render(root, [{tag: component, attrs: component}])
render(root, [])
o(onremove.callCount).equals(2) // once for `tag`, once for `attrs`
})
o("doesn't finalize prematurely if `done` is called twice in the `tag` hook", function(done) {
var async = false
var component = {
view: function(){return {tag:'br'}},
onbeforeremove: function(vnode, doneRemoving){
doneRemoving()
doneRemoving()
},
onremove: function(){
o(async).equals(true)("onremove should be called asynchronously")
done()
}
}
render(root, [{tag:component, attrs: {onbeforeremove: function(vnode, doneRemoving){
callAsync(doneRemoving)
}}}])
render(root, [])
async = true
})
})

11
render/tests/test-onremove.js
View file

@ -145,4 +145,15 @@ o.spec("onremove", function() {
o(vnode.dom).notEquals(updated.dom)
})
o("The remove phase is finalized only once when `done()` is called synchronously from both attrs- and tag.onbeforeremove", function () {
var onremove = o.spy()
var component = {
view: function(){return m('br')},
onbeforeremove: function(vnode, done){done()},
onremove: onremove
}
render(root, [{tag: component, attrs: component}])
render(root, [])
o(onremove.callCount).equals(2)
})
})