vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent undesired Date parsing

Browse source 
Native Date parsing is unpredictable and will occasionally turn a string
like "/foo/1" into a valid date of Jan 1, 2001.  This can be prevented
by not parsing a string that begins with a slash.

It's likely that this is a rare case, but it's annoying when it does
come up.
This commit is contained in:
Douglas Brown 2016-09-15 11:32:34 -04:00
parent 91851e2025
commit 391e7f43f5
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
querystring/parse.js
View file

@ -15,7 +15,7 @@ module.exports = function(string) {
if (value !== "" && !isNaN(number) || value === "NaN") value = number if (value !== "" && !isNaN(number) || value === "NaN") value = number
else if (value === "true") value = true else if (value === "true") value = true
else if (value === "false") value = false else if (value === "false") value = false
else { else if (value.charAt(0) !== "/") {
var date = new Date(value) var date = new Date(value)
if (!isNaN(date.getTime())) value = date if (!isNaN(date.getTime())) value = date
} }

4
querystring/tests/test-parseQueryString.js
View file

@ -20,6 +20,10 @@ o.spec("parseQueryString", function() {
var data = parseQueryString("?%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23=%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23") var data = parseQueryString("?%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23=%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23")
o(data).deepEquals({";:@&=+$,/?%#": ";:@&=+$,/?%#"}) o(data).deepEquals({";:@&=+$,/?%#": ";:@&=+$,/?%#"})
}) })
o("handles escaped slashes followed by a number", function () {
var data = parseQueryString("?hello=%2Fen%2F1")
o(data.hello).equals("/en/1")
})
o("handles escaped square brackets", function() { o("handles escaped square brackets", function() {
var data = parseQueryString("?a%5B%5D=b") var data = parseQueryString("?a%5B%5D=b")
o(data).deepEquals({"a": ["b"]}) o(data).deepEquals({"a": ["b"]})