vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pass namespace when creating new elements while updating a keyed list, fix #1820

Browse source
This commit is contained in:
Pierre-Yves Gerardy 2017-05-30 14:17:46 +02:00
parent 29bc42b574
commit 40429c8377
2 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/render.js
View file

@ -224,7 +224,7 @@ module.exports = function($window) {
if (movable.dom != null) nextSibling = movable.dom if (movable.dom != null) nextSibling = movable.dom
} }
else { else {
var dom = createNode(parent, v, hooks, undefined, nextSibling) var dom = createNode(parent, v, hooks, ns, nextSibling)
nextSibling = dom nextSibling = dom
} }
} }

22
render/tests/test-render.js
View file

@ -271,4 +271,26 @@ o.spec("render", function() {
o(updateA.callCount).equals(2) o(updateA.callCount).equals(2)
o(removeA.callCount).equals(1) o(removeA.callCount).equals(1)
}) })
o("svg namespace is preserved in keyed diff (#1820)", function(){
// note that this only exerciese one branch of the keyed diff algo
var svg = {tag:"svg", children: [
{tag:"g", key: 0},
{tag:"g", key: 1}
]}
render(root, [svg])
o(svg.dom.namespaceURI).equals("http://www.w3.org/2000/svg")
o(svg.dom.childNodes[0].namespaceURI).equals("http://www.w3.org/2000/svg")
o(svg.dom.childNodes[1].namespaceURI).equals("http://www.w3.org/2000/svg")
svg = {tag:"svg", children: [
{tag:"g", key: 1, attrs: {x: 1}},
{tag:"g", key: 2, attrs: {x: 2}}
]}
render(root, [svg])
o(svg.dom.namespaceURI).equals("http://www.w3.org/2000/svg")
o(svg.dom.childNodes[0].namespaceURI).equals("http://www.w3.org/2000/svg")
o(svg.dom.childNodes[1].namespaceURI).equals("http://www.w3.org/2000/svg")
})
}) })