m.route tests should run against all prefixes

Also tests `router.link` now. Had to add a `preventDefault` function to
domMock events that doesn't do anything, that may need a more-complete
implementation someday?
This commit is contained in:
Pat Cavit 2016-05-19 00:09:20 -07:00 committed by Pat Cavit
parent 89dfd6e97d
commit 41b24b998a
2 changed files with 166 additions and 81 deletions

View file

@ -8,85 +8,167 @@ var async = require("./async")
var m = require("../../render/hyperscript")
var createRouter = require("../router")
o.spec("m.mount", function() {
var $window, root
o.spec("m.route", function() {
var $window, root, router
o.beforeEach(function() {
var dom = domMock()
var location = pushStateMock()
["#", "?", "", "#!", "?!"].forEach(function(prefix) {
var spec = prefix ? "prefix " + prefix : "pushstate";
Object.keys(location).forEach(function(key) {
dom[key] = location[key]
})
o.spec(spec, function() {
o.beforeEach(function() {
var dom = domMock()
var location = pushStateMock()
$window = dom
async.setTimeout($window)
root = $window.document.body
})
// Generate a DOM + Location mock
Object.keys(location).forEach(function(key) {
dom[key] = location[key]
})
o("is a function", function() {
o(typeof createRouter).equals("function")
})
$window = dom
async.setTimeout($window)
root = $window.document.body
})
o("returns a function after invocation", function() {
o(typeof createRouter($window)).equals("function")
})
o("is a function", function() {
o(typeof createRouter).equals("function")
})
o("updates passed in redraw object", function() {
var redraw = {}
var router = createRouter($window, redraw)
o("returns a function after invocation", function() {
o(typeof createRouter($window)).equals("function")
})
router(root, "/", {
"/" : {
view : function() {
return m("div")
}
}
})
o("updates passed in redraw object", function() {
var redraw = {}
var router = createRouter($window, redraw)
o(typeof redraw.run).equals("function")
})
router.prefix = prefix
o("renders into `root`", function() {
var router = createRouter($window, {})
router(root, "/", {
"/" : {
view: function() {
return m("div")
}
}
})
router(root, "/", {
"/" : {
view : function() {
return m("div")
}
}
})
o(typeof redraw.run).equals("function")
})
o(root.firstChild.nodeName).equals("DIV")
})
o("renders into `root`", function() {
var router = createRouter($window, {})
o("redraws on redraw.run()", function(done) {
var onupdate = o.spy()
var oninit = o.spy()
var redraw = {}
var router = createRouter($window, redraw)
router.prefix = prefix
router(root, "/", {
"/" : {
view : function() {
return m("div", {
oninit : oninit,
onupdate : onupdate
})
}
}
})
router(root, "/", {
"/" : {
view: function() {
return m("div")
}
}
})
o(oninit.callCount).equals(1)
o(root.firstChild.nodeName).equals("DIV")
})
redraw.run()
o("redraws on redraw.run()", function(done) {
var onupdate = o.spy()
var oninit = o.spy()
var redraw = {}
var router = createRouter($window, redraw)
// Wrapped to give time for the rate-limited redraw to fire
setTimeout(function() {
o(onupdate.callCount).equals(1)
router.prefix = prefix
done()
}, 20)
})
router(root, "/", {
"/" : {
view: function() {
return m("div", {
oninit: oninit,
onupdate: onupdate
})
}
}
})
o(oninit.callCount).equals(1)
redraw.run()
// Wrapped to give time for the rate-limited redraw to fire
setTimeout(function() {
o(onupdate.callCount).equals(1)
done()
}, 20)
})
o("redraws on events", function(done, timeout) {
var onupdate = o.spy()
var oninit = o.spy()
var onclick = o.spy()
var router = createRouter($window, {})
var e = $window.document.createEvent("MouseEvents")
e.initEvent("click", true, true)
router.prefix = prefix
router(root, "/", {
"/" : {
view: function() {
return m("div", {
oninit: oninit,
onupdate: onupdate,
onclick: onclick,
})
}
}
})
root.firstChild.dispatchEvent(e)
o(oninit.callCount).equals(1)
o(onclick.callCount).equals(1)
o(onclick.this).equals(root.firstChild)
o(onclick.args[0].type).equals("click")
o(onclick.args[0].target).equals(root.firstChild)
// Wrapped to give time for the rate-limited redraw to fire
setTimeout(function() {
o(onupdate.callCount).equals(1)
done()
}, 20)
})
o("changes location on route.link", function() {
var router = createRouter($window, {})
var e = $window.document.createEvent("MouseEvents")
e.initEvent("click", true, true)
router.prefix = prefix
router(root, "/", {
"/" : {
view: function() {
return m("a", {
href: "/test",
oncreate: router.link
})
}
},
"/test" : {
view : function() {
return m("div")
}
}
})
root.firstChild.dispatchEvent(e)
o($window.location.href).equals("http://localhost/" + prefix + "/test")
})
})
})
})

View file

@ -173,6 +173,9 @@ module.exports = function() {
events[e.type][i].call(this, e)
}
}
e.preventDefault = function() {
// TODO: should this do something?
}
if (typeof this["on" + e.type] === "function" && !isModernEvent(e.type)) this["on" + e.type](e)
},
}