From 41d3ee2983afbdef2a241fa0776f93982a600299 Mon Sep 17 00:00:00 2001 From: Leo Horie Date: Mon, 26 May 2014 21:59:41 -0400 Subject: [PATCH] prevent null ref --- mithril.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mithril.js b/mithril.js index 11a8c69e..1234d759 100644 --- a/mithril.js +++ b/mithril.js @@ -162,10 +162,7 @@ Mithril = m = new function app(window) { return cachedAttrs } function clear(nodes) { - if (nodes.length > 0) { - var parent = nodes[i].parentNode - for (var i = nodes.length - 1; i > -1; i--) parent.removeChild(nodes[i]) - } + for (var i = nodes.length - 1; i > -1; i--) if (nodes[i]) nodes[i].parentNode.removeChild(nodes[i]) nodes.length = 0 } function injectHTML(parentElement, index, data) { @@ -209,6 +206,7 @@ Mithril = m = new function app(window) { } var nodeCache = [], cellCache = {} m.render = function(root, cell) { + if (!root) throw new Error("Please ensure the DOM element exists before rendering a template into it.") var index = nodeCache.indexOf(root) var id = index < 0 ? nodeCache.push(root) - 1 : index var node = root == window.document || root == window.document.documentElement ? documentNode : root