vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1890 from pygy/fix-1850

Browse source 
Reset e.redraw when it was set to `false`. Fixes #1850
This commit is contained in:
Pierre-Yves Gérardy 2017-07-06 21:08:30 +02:00 • committed by GitHub
commit 4a001267d0
3 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
api/redraw.js
View file

@ -26,7 +26,8 @@ function throttle(callback) {
module.exports = function($window) { module.exports = function($window) {
var renderService = coreRenderer($window) var renderService = coreRenderer($window)
renderService.setEventCallback(function(e) { renderService.setEventCallback(function(e) {
if (e.redraw !== false) redraw() if (e.redraw === false) e.redraw = undefined
else redraw()
}) })
var callbacks = [] var callbacks = []

3
api/tests/test-mount.js
View file

@ -5,7 +5,6 @@ var components = require("../../test-utils/components")
var domMock = require("../../test-utils/domMock") var domMock = require("../../test-utils/domMock")
var m = require("../../render/hyperscript") var m = require("../../render/hyperscript")
var coreRenderer = require("../../render/render")
var apiRedraw = require("../../api/redraw") var apiRedraw = require("../../api/redraw")
var apiMounter = require("../../api/mount") var apiMounter = require("../../api/mount")
@ -20,7 +19,7 @@ o.spec("mount", function() {
redrawService = apiRedraw($window) redrawService = apiRedraw($window)
mount = apiMounter(redrawService) mount = apiMounter(redrawService)
render = coreRenderer($window).render render = redrawService.render
}) })
o("throws on invalid component", function() { o("throws on invalid component", function() {

4
api/tests/test-router.js
View file

@ -224,9 +224,11 @@ o.spec("route", function() {
} }
}) })
o(oninit.callCount).equals(1)
root.firstChild.dispatchEvent(e) root.firstChild.dispatchEvent(e)
o(oninit.callCount).equals(1) o(e.redraw).notEquals(false)
// Wrapped to ensure no redraw fired // Wrapped to ensure no redraw fired
callAsync(function() { callAsync(function() {