From 542b87889b20d9f6170ae8c12e46cdd2946a31bb Mon Sep 17 00:00:00 2001 From: mpfau Date: Thu, 19 Jan 2017 19:04:53 +0100 Subject: [PATCH] docs: fix onremove lifecycle doc (#1552) Fixed the description of onremove to match the current implementation of onbeforeremove (promise vs. done callback) --- docs/lifecycle-methods.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/lifecycle-methods.md b/docs/lifecycle-methods.md index a7eb2315..cac48a82 100644 --- a/docs/lifecycle-methods.md +++ b/docs/lifecycle-methods.md @@ -154,7 +154,7 @@ var Fader = { ### onremove -The `onremove(vnode)` hook is called before a DOM element is removed from the document. If a `onbeforeremove` hook is also defined, the `onremove` hook runs after the `done` callback is called. +The `onremove(vnode)` hook is called before a DOM element is removed from the document. If a `onbeforeremove` hook is also defined, the `onremove` hook runs after the promise returned from `onbeforeremove` is completed. This hook is called on any element that is removed from the document, regardless of whether it was directly detached from its parent or whether it is a child of another element that was detached.