From 5fd2e99831bbad04a4dcd9a3d8c992ebc1bf73c2 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Gerardy Date: Fri, 5 Aug 2016 12:38:31 +0200 Subject: [PATCH] Fix the domMock and domMock tests for cssText support --- test-utils/domMock.js | 6 +++++- test-utils/tests/test-domMock.js | 20 +++++++++++++++----- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/test-utils/domMock.js b/test-utils/domMock.js index 0af6b252..cde58a24 100644 --- a/test-utils/domMock.js +++ b/test-utils/domMock.js @@ -136,7 +136,11 @@ module.exports = function() { get style() { return style }, - set style(value) { + set style(_){ + // https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style#Setting_style + throw new Error("setting element.style is not portable") + }, + set cssText(value) { if (typeof value === "string") { for (var key in style) style[key] = "" var rules = value.split(";") diff --git a/test-utils/tests/test-domMock.js b/test-utils/tests/test-domMock.js index 527b4e61..2b589673 100644 --- a/test-utils/tests/test-domMock.js +++ b/test-utils/tests/test-domMock.js @@ -474,20 +474,30 @@ o.spec("domMock", function() { o(typeof div.style).equals("object") }) - o("setting style string works", function() { + o("setting cssText string works", function() { var div = $document.createElement("div") - div.style = "background-color: red; border-bottom: 1px solid red;" + div.cssText = "background-color: red; border-bottom: 1px solid red;" o(div.style.backgroundColor).equals("red") o(div.style.borderBottom).equals("1px solid red") }) - o("removing via setting style string works", function() { + o("removing via setting cssText string works", function() { var div = $document.createElement("div") - div.style = "background: red;" - div.style = "" + div.cssText = "background: red;" + div.cssText = "" o(div.style.background).equals("") }) + o("setting style throws", function () { + var err = false + try { + div.style = '' + } catch (e) { + err = e + } + + o(err instanceof Error).equals(true) + }) }) o.spec("events", function() { o.spec("click", function() {