vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

prevent early redraw if controller goes async

Browse source
This commit is contained in:
Leo Horie 2015-02-26 22:28:28 -05:00
parent 06c6e56cc4
commit 643e85cd5b
1 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
mithril.js
View file

@ -233,10 +233,10 @@ var m = (function app(window, undefined) {
} }
else if (data != null && dataType === OBJECT) { else if (data != null && dataType === OBJECT) {
if (data.view) { if (data.view) {
var module = data var module = data, onunload
var controller = cached.controller || new (module.controller || function() {}) var controller = cached.controller || new (module.controller || function() {})
data = pendingRequests == 0 ? module.view(controller) : {tag: "placeholder"}
if (controller.onunload) unloaders.push({controller: controller, handler: controller.onunload}) if (controller.onunload) unloaders.push({controller: controller, handler: controller.onunload})
data = module.view(controller)
if (!data.tag) throw new Error("Component template must return a virtual element, not an array, string, etc.") if (!data.tag) throw new Error("Component template must return a virtual element, not an array, string, etc.")
} }
if (!data.attrs) data.attrs = {}; if (!data.attrs) data.attrs = {};
@ -269,7 +269,15 @@ var m = (function app(window, undefined) {
data.children, data.children,
nodes: [node] nodes: [node]
}; };
if (controller) cached.controller = controller if (controller) {
cached.controller = controller
if (controller.onunload.$old) controller.onunload = controller.onunload.$old
if (pendingRequests && controller.onunload) {
var onunload = controller.onunload
controller.onunload = function() {}
controller.onunload.$old = onunload
}
}
if (cached.children && !cached.children.nodes) cached.children.nodes = []; if (cached.children && !cached.children.nodes) cached.children.nodes = [];
//edge case: setting value on <select> doesn't work before children exist, so set it again after children have been created //edge case: setting value on <select> doesn't work before children exist, so set it again after children have been created