vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#278 fix select[multiple] w/ many option[selected]

Browse source
This commit is contained in:
Leo Horie 2014-10-04 12:28:57 -04:00
parent d7c11f530c
commit 67666e76dd
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
mithril.js
View file

@ -210,11 +210,13 @@ Mithril = m = new function app(window, undefined) {
node = namespace === undefined ? window.document.createElement(data.tag) : window.document.createElementNS(namespace, data.tag) node = namespace === undefined ? window.document.createElement(data.tag) : window.document.createElementNS(namespace, data.tag)
cached = { cached = {
tag: data.tag, tag: data.tag,
//process children before attrs so that select.value works correctly //set attributes first, then create children
children: build(node, data.tag, undefined, undefined, data.children, cached.children, true, 0, data.attrs.contenteditable ? node : editable, namespace, configs),
attrs: setAttributes(node, data.tag, data.attrs, {}, namespace), attrs: setAttributes(node, data.tag, data.attrs, {}, namespace),
children: build(node, data.tag, undefined, undefined, data.children, cached.children, true, 0, data.attrs.contenteditable ? node : editable, namespace, configs),
nodes: [node] nodes: [node]
} }
//edge case: setting value on <select> doesn't work before children exist, so set it again after children have been created
if (data.tag == "select" && data.attrs.value) setAttributes(node, data.tag, {value: data.attrs.value}, {}, namespace)
parentElement.insertBefore(node, parentElement.childNodes[index] || null) parentElement.insertBefore(node, parentElement.childNodes[index] || null)
} }
else { else {
@ -927,7 +929,7 @@ Mithril = m = new function app(window, undefined) {
} }
//testing API //testing API
m.deps = function(mock) {return window = mock} m.deps = function(mock) {return window = mock || window}
//for internal testing only, do not use `m.deps.factory` //for internal testing only, do not use `m.deps.factory`
m.deps.factory = app m.deps.factory = app