From 68331065b7a14a14cae25bafa4f1688936cfc68f Mon Sep 17 00:00:00 2001 From: Leo Horie Date: Fri, 12 Aug 2016 23:56:17 -0400 Subject: [PATCH] more router tests --- api/router.js | 2 +- api/tests/test-router.js | 72 ++++++++++++++++++++++++++++++---------- 2 files changed, 55 insertions(+), 19 deletions(-) diff --git a/api/router.js b/api/router.js index 2ca45757..396b688e 100644 --- a/api/router.js +++ b/api/router.js @@ -7,7 +7,7 @@ var autoredraw = require("../api/autoredraw") module.exports = function($window, renderer, pubsub) { var router = coreRouter($window) var route = function(root, defaultRoute, routes) { - var current = {path: null, component: null} + var current = {path: null, component: "div"} var replay = router.defineRoutes(routes, function(payload, args, path, route) { if (typeof payload.view !== "function") { if (typeof payload.render !== "function") payload.render = function(vnode) {return vnode} diff --git a/api/tests/test-router.js b/api/tests/test-router.js index 713f9bf1..fdbc0054 100644 --- a/api/tests/test-router.js +++ b/api/tests/test-router.js @@ -232,6 +232,8 @@ o.spec("route", function() { }) o("accepts object as payload", function(done) { + var resolveCount = 0 + var renderCount = 0 var Component = { view: function() { return m("div") @@ -239,21 +241,38 @@ o.spec("route", function() { } $window.location.href = prefix + "/" - route(root, "/", { - "/" : { - resolve: function(resolve) {resolve(Component)}, - render: function(vnode) {return vnode}, + route(root, "/abc", { + "/:id" : { + resolve: function(use, args, path, route) { + resolveCount++ + + o(args).deepEquals({id: "abc"}) + o(path).equals("/abc") + o(route).equals("/:id") + + use(Component) + }, + render: function(vnode) { + renderCount++ + + o(vnode.attrs).deepEquals({id: "abc"}) + + return vnode + }, }, }) - callAsync(function() { + setTimeout(function() { + o(resolveCount).equals(1) + o(renderCount).equals(1) o(root.firstChild.nodeName).equals("DIV") done() - }) + }, FRAME_BUDGET) }) o("accepts object without `render` method as payload", function(done) { + var resolveCount = 0 var Component = { view: function() { return m("div") @@ -261,20 +280,31 @@ o.spec("route", function() { } $window.location.href = prefix + "/" - route(root, "/", { - "/" : { - resolve: function(resolve) {resolve(Component)}, + route(root, "/abc", { + "/:id" : { + resolve: function(use, args, path, route) { + resolveCount++ + + o(args).deepEquals({id: "abc"}) + o(path).equals("/abc") + o(route).equals("/:id") + + use(Component) + }, }, }) - callAsync(function() { + setTimeout(function() { + o(resolveCount).equals(1) + o(root.firstChild.nodeName).equals("DIV") done() - }) + }, FRAME_BUDGET) }) o("accepts object without `resolve` method as payload", function(done) { + var renderCount = 0 var Component = { view: function() { return m("div") @@ -282,17 +312,23 @@ o.spec("route", function() { } $window.location.href = prefix + "/" - route(root, "/", { - "/" : { - render: function() {return m(Component)}, + route(root, "/abc", { + "/:id" : { + render: function(vnode) { + renderCount++ + + o(vnode.attrs).deepEquals({id: "abc"}) + + return m(Component) + }, }, }) - callAsync(function() { + setTimeout(function() { o(root.firstChild.nodeName).equals("DIV") done() - }) + }, FRAME_BUDGET) }) o("calls resolve and render correct number of times", function(done) { @@ -307,9 +343,9 @@ o.spec("route", function() { $window.location.href = prefix + "/" route(root, "/", { "/" : { - resolve: function(resolve) { + resolve: function(use) { resolveCount++ - resolve(Component) + use(Component) }, render: function(vnode) { renderCount++