vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Gotchas imply onbeforeupdate is inherently evil

Browse source 
The premature optimisation warning talks about `onbeforeupdate` as though returning false were its only purpose. In fact it's also useful for transforming simple input into a detailed model for the view, input-state comparisons for change highlighting, etc.
This commit is contained in:
Barney Carroll 2016-07-29 10:55:37 +01:00 • committed by GitHub
parent 0ac6ef44b8
commit 6c061a3170
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/lifecycle-methods.md
View file

@ -252,7 +252,7 @@ var WorkingComponent = {
#### Avoid premature optimizations
The `onbeforeupdate` hook should only be used as a last resort. Avoid using it unless you have a noticeable performance issue.
You should only use `onbeforeupdate` to skip diffing as a last resort. Avoid using it unless you have a noticeable performance issue.
Typically performance problems that can be fixed via `onbeforeupdate` boil down to one large array of items. In this context, typically "large" means any array that contains a large number of nodes, be it in a wide spread (the infamous 5000 row table), or in a deep, dense tree.