vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hyperscript: handles shared empty attrs, fixes #2821

Browse source
This commit is contained in:
Keita Furui 2023-02-15 11:11:18 +09:00 • committed by Claudia Meadows
parent 274cb2fff2
commit 6c1c5cf106
No known key found for this signature in database
GPG key ID: C86B594396786760
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/hyperscript.js
View file

@ -38,7 +38,7 @@ function execSelector(state, vnode) {
vnode.tag = state.tag vnode.tag = state.tag
vnode.attrs = {} vnode.attrs = {}
if (!isEmpty(state.attrs) && !isEmpty(attrs)) { if (!isEmpty(state.attrs)) {
var newAttrs = {} var newAttrs = {}
for (var key in attrs) { for (var key in attrs) {

9
render/tests/test-hyperscript.js
View file

@ -580,6 +580,15 @@ o.spec("hyperscript", function() {
o(nodeB.attrs.className).equals("b") o(nodeB.attrs.className).equals("b")
o(nodeB.attrs.a).equals("b") o(nodeB.attrs.a).equals("b")
}) })
o("handles shared empty attrs (#2821)", function() {
var attrs = {}
var nodeA = m(".a", attrs)
var nodeB = m(".b", attrs)
o(nodeA.attrs.className).equals("a")
o(nodeB.attrs.className).equals("b")
})
o("doesnt modify passed attributes object", function() { o("doesnt modify passed attributes object", function() {
var attrs = {a: "b"} var attrs = {a: "b"}
m(".a", attrs) m(".a", attrs)