vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#1281 fixed recyling edge case

Browse source
This commit is contained in:
Leo Horie 2016-10-04 16:33:57 -04:00
parent 59e4e8ff26
commit 730c960416
5 changed files with 85 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

8
render/render.js
View file

@ -132,7 +132,7 @@ module.exports = function($window) {
var oldStart = 0, start = 0, oldEnd = old.length - 1, end = vnodes.length - 1, map
while (oldEnd >= oldStart && end >= start) {
var o = old[oldStart], v = vnodes[start]
if (o === v) oldStart++, start++
if (o === v && !recycling) oldStart++, start++
else if (o != null && v != null && o.key === v.key) {
oldStart++, start++
updateNode(parent, o, v, hooks, getNextSibling(old, oldStart, nextSibling), recycling, ns)
@ -140,10 +140,10 @@ module.exports = function($window) {
}
else {
var o = old[oldEnd]
if (o === v) oldEnd--, start++
if (o === v && !recycling) oldEnd--, start++
else if (o != null && v != null && o.key === v.key) {
updateNode(parent, o, v, hooks, getNextSibling(old, oldEnd + 1, nextSibling), recycling, ns)
if (start < end) insertNode(parent, toFragment(o), getNextSibling(old, oldStart, nextSibling))
if (recycling || start < end) insertNode(parent, toFragment(o), getNextSibling(old, oldStart, nextSibling))
oldEnd--, start++
}
else break
@ -151,7 +151,7 @@ module.exports = function($window) {
}
while (oldEnd >= oldStart && end >= start) {
var o = old[oldEnd], v = vnodes[end]
if (o === v) oldEnd--, end--
if (o === v && !recycling) oldEnd--, end--
else if (o != null && v != null && o.key === v.key) {
updateNode(parent, o, v, hooks, getNextSibling(old, oldEnd + 1, nextSibling), recycling, ns)
if (recycling && o.tag === v.tag) insertNode(parent, toFragment(o), nextSibling)