From 795f09840403d2c1eaad9ef9c534ca12f62e36ef Mon Sep 17 00:00:00 2001 From: Syaiful Bahri Date: Tue, 29 Dec 2015 09:58:26 +0700 Subject: [PATCH] Fix onunload test case - the previous test only remove last item on array, but expect all subcomponent's onunload to be called. This PR change it by clear that array. - uncomment previous test case that marked fail. --- test/mithril.mount.js | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/test/mithril.mount.js b/test/mithril.mount.js index dadf0b9d..275e1c2b 100644 --- a/test/mithril.mount.js +++ b/test/mithril.mount.js @@ -333,12 +333,11 @@ describe("m.mount()", function () { }) })) - list.pop() + list = [] refresh(true) - // TODO: These fail. - // expect(spies[1]).to.have.been.called - // expect(spies[2]).to.have.been.called + expect(spies[1]).to.have.been.called + expect(spies[2]).to.have.been.called expect(spies[3]).to.have.been.called }) @@ -374,17 +373,15 @@ describe("m.mount()", function () { }) })) - list.pop() + list = [] refresh(true) - // TODO: These fail. - // expect(spies1[1]).to.have.been.called - // expect(spies1[2]).to.have.been.called + expect(spies1[1]).to.have.been.called + expect(spies1[2]).to.have.been.called expect(spies1[3]).to.have.been.called - // TODO: These fail. - // expect(spies2[1]).to.have.been.called - // expect(spies2[2]).to.have.been.called + expect(spies2[1]).to.have.been.called + expect(spies2[2]).to.have.been.called expect(spies2[3]).to.have.been.called })