vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better tests for Promise.prototype.finally

Browse source
This commit is contained in:
Pierre-Yves Gérardy 2018-02-20 00:27:39 +01:00 • committed by GitHub
parent e05fb0b048
commit 8217d68e18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 65 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

83
promise/tests/test-promise.js
View file

@ -54,30 +54,77 @@ o.spec("promise", function() {
o(value).equals(1) o(value).equals(1)
}).then(done) }).then(done)
}) })
o("finally returns promise", function(done) { o("finally lets a fulfilled value pass though", function(done) {
var promise = Promise.resolve(1) var promise = Promise.resolve(1)
var spy = o.spy(function(){return 2})
promise.finally(function(value) { promise.finally(spy).then(function(value){
o(value).equals(undefined)
}).finally(done)
})
o("finally after then returns promise", function(done) {
var promise = Promise.resolve(1)
promise.then(function(value) {
o(value).equals(1) o(value).equals(1)
}).finally(function(value) { o(spy.callCount).equals(1)
o(value).equals(undefined) o(spy.args.length).equals(0)
}).then(done) o(spy.this).equals(undefined)
done()
})
}) })
o("finally after catch returns promise", function(done) { o("finally lets a rejected reason pass though", function(done) {
var promise = Promise.reject(1) var promise = Promise.reject(1)
var spy = o.spy(function(){return 2})
promise.catch(function(value) { promise.finally(spy).catch(function(reason){
o(value).equals(1) o(reason).equals(1)
}).finally(function(value) { o(spy.callCount).equals(1)
o(value).equals(undefined) o(spy.args.length).equals(0)
}).then(done) o(spy.this).equals(undefined)
done()
})
})
o("finally overrrides a fulfilled value when it throws", function(done) {
var promise = Promise.resolve(1)
var spy = o.spy(function(){throw 2})
promise.finally(spy).catch(function(reason){
o(reason).equals(2)
o(spy.callCount).equals(1)
o(spy.args.length).equals(0)
o(spy.this).equals(undefined)
done()
})
})
o("finally overrrides a fulfilled value when it returns a rejected Promise", function(done) {
var promise = Promise.resolve(1)
var spy = o.spy(function(){return Promise.reject(2)})
promise.finally(spy).catch(function(reason){
o(reason).equals(2)
o(spy.callCount).equals(1)
o(spy.args.length).equals(0)
o(spy.this).equals(undefined)
done()
})
})
o("finally overrrides a rejected reason when it throws", function(done) {
var promise = Promise.reject(1)
var spy = o.spy(function(){throw 2})
promise.finally(spy).catch(function(reason){
o(reason).equals(2)
o(spy.callCount).equals(1)
o(spy.args.length).equals(0)
o(spy.this).equals(undefined)
done()
})
})
o("finally overrrides a rejected reason when it returns a rejected Promise", function(done) {
var promise = Promise.reject(1)
var spy = o.spy(function(){return Promise.reject(2)})
promise.finally(spy).catch(function(reason){
o(reason).equals(2)
o(spy.callCount).equals(1)
o(spy.args.length).equals(0)
o(spy.this).equals(undefined)
done()
})
}) })
}) })
o.spec("resolve", function() { o.spec("resolve", function() {