vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clarify pathname docs, follow spec with fragments (#2448)

Browse source 
* Clarify pathname docs, follow spec with fragments

- Valid URLs must not contain a `#` within its fragment.
  https://github.com/MithrilJS/mithril.js/issues/2445
- Our docs were a little confusing and misleading - `m.pathname` isn't
  aware of URLs, just path names.
- Removed the relevant extension to `m.parseQueryString` required to
  support the hash parsing extension. Now we just shave it off and
  ignore it.
- Fix support for arbitrary prefixes, so prefixes like `?#` are
  handled correctly.
- Add a bunch of tests to cover various areas of confusion and unusual
  edge cases.

* Update with PR [skip ci]
This commit is contained in:
Isiah Meadows 2019-07-03 06:22:25 -04:00 • committed by GitHub
parent 9e9b89d900
commit 85bfd0f77d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 85 additions and 127 deletions
Download patch file Download diff file Expand all files Collapse all files

38
pathname/tests/test-parsePathname.js
View file

@ -18,18 +18,18 @@ o.spec("parsePathname", function() {
params: {a: "b", c: "d"}
})
})
o("parses hash at start", function() {
o("ignores hash at start", function() {
var data = parsePathname("#a=b&c=d")
o(data).deepEquals({
path: "/",
params: {a: "b", c: "d"}
params: {}
})
})
o("parses query + hash at start", function() {
o("parses query, ignores hash at start", function() {
var data = parsePathname("?a=1&b=2#c=3&d=4")
o(data).deepEquals({
path: "/",
params: {a: "1", b: "2", c: "3", d: "4"}
params: {a: "1", b: "2"}
})
})
o("parses root", function() {
@ -46,18 +46,18 @@ o.spec("parsePathname", function() {
params: {a: "b", c: "d"}
})
})
o("parses root + hash at start", function() {
o("parses root, ignores hash at start", function() {
var data = parsePathname("/#a=b&c=d")
o(data).deepEquals({
path: "/",
params: {a: "b", c: "d"}
params: {}
})
})
o("parses root + query + hash at start", function() {
o("parses root + query, ignores hash at start", function() {
var data = parsePathname("/?a=1&b=2#c=3&d=4")
o(data).deepEquals({
path: "/",
params: {a: "1", b: "2", c: "3", d: "4"}
params: {a: "1", b: "2"}
})
})
o("parses route", function() {
@ -102,25 +102,25 @@ o.spec("parsePathname", function() {
params: {c: "3", d: "4"}
})
})
o("parses route + query + hash", function() {
o("parses route + query, ignores hash", function() {
var data = parsePathname("/route/foo?a=1&b=2#c=3&d=4")
o(data).deepEquals({
path: "/route/foo",
params: {a: "1", b: "2", c: "3", d: "4"}
params: {a: "1", b: "2"}
})
})
o("deduplicates same-named params in query + hash", function() {
var data = parsePathname("/route/foo?a=1&b=2#a=3&c=4")
o(data).deepEquals({
path: "/route/foo",
params: {a: "3", b: "2", c: "4"}
})
})
o("parses route + query + hash with lots of junk slashes", function() {
o("parses route + query, ignores hash with lots of junk slashes", function() {
var data = parsePathname("//route/////foo//?a=1&b=2#c=3&d=4")
o(data).deepEquals({
path: "/route/foo",
params: {a: "1", b: "2", c: "3", d: "4"}
params: {a: "1", b: "2"}
})
})
o("doesn't comprehend protocols", function() {
var data = parsePathname("https://example.com/foo/bar")
o(data).deepEquals({
path: "/https:/example.com/foo/bar",
params: {}
})
})
})