vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add tentative fix for #29

Browse source 
https://github.com/lhorie/mithril.js/issues/29

TODO: test cost of relying on native equality checks
This commit is contained in:
Leo Horie 2014-03-30 22:33:49 -04:00
parent 62eae50b20
commit 86ba3474a6
5 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
archive/v0.1.2/mithril-tests.js
View file

@ -119,14 +119,14 @@ new function(window) {
function setAttributes(node, dataAttrs, cachedAttrs) { function setAttributes(node, dataAttrs, cachedAttrs) {
for (var attrName in dataAttrs) { for (var attrName in dataAttrs) {
var dataAttr = dataAttrs[attrName] var dataAttr = dataAttrs[attrName]
if (!(attrName in cachedAttrs) || (cachedAttrs[attrName] !== dataAttr)) { //if (!(attrName in cachedAttrs) || (cachedAttrs[attrName] !== dataAttr)) {
cachedAttrs[attrName] = dataAttr cachedAttrs[attrName] = dataAttr
if (attrName == "config") continue if (attrName == "config") continue
if (attrName.indexOf("on") == 0 && typeof dataAttr == "function") dataAttr = autoredraw(dataAttr, node) if (attrName.indexOf("on") == 0 && typeof dataAttr == "function") dataAttr = autoredraw(dataAttr, node)
if (attrName == "style") for (var rule in dataAttr) node.style[rule] = dataAttr[rule] if (attrName == "style") for (var rule in dataAttr) node.style[rule] = dataAttr[rule]
else if (attrName in node) node[attrName] = dataAttr else if (attrName in node) node[attrName] = dataAttr
else node.setAttribute(attrName, dataAttr) else node.setAttribute(attrName, dataAttr)
} //}
} }
return cachedAttrs return cachedAttrs
} }
@ -180,6 +180,7 @@ new function(window) {
var currentRoot, currentModule = {view: function() {}}, currentController = {}, now = 0, lastRedraw = 0, lastRedrawId = 0 var currentRoot, currentModule = {view: function() {}}, currentController = {}, now = 0, lastRedraw = 0, lastRedrawId = 0
m.module = function(root, module) { m.module = function(root, module) {
m.startComputation() m.startComputation()
cellCache = {}
currentRoot = root currentRoot = root
currentModule = module currentModule = module
currentController = new module.controller currentController = new module.controller

2
archive/v0.1.2/mithril.min.js vendored
View file

File diff suppressed because one or more lines are too long

2
archive/v0.1.2/mithril.min.map
View file

File diff suppressed because one or more lines are too long

BIN
archive/v0.1.2/mithril.min.zip
View file

Binary file not shown.

4
mithril.js
View file

@ -119,14 +119,14 @@ new function(window) {
function setAttributes(node, dataAttrs, cachedAttrs) { function setAttributes(node, dataAttrs, cachedAttrs) {
for (var attrName in dataAttrs) { for (var attrName in dataAttrs) {
var dataAttr = dataAttrs[attrName] var dataAttr = dataAttrs[attrName]
if (!(attrName in cachedAttrs) || (cachedAttrs[attrName] !== dataAttr)) { //if (!(attrName in cachedAttrs) || (cachedAttrs[attrName] !== dataAttr)) {
cachedAttrs[attrName] = dataAttr cachedAttrs[attrName] = dataAttr
if (attrName == "config") continue if (attrName == "config") continue
if (attrName.indexOf("on") == 0 && typeof dataAttr == "function") dataAttr = autoredraw(dataAttr, node) if (attrName.indexOf("on") == 0 && typeof dataAttr == "function") dataAttr = autoredraw(dataAttr, node)
if (attrName == "style") for (var rule in dataAttr) node.style[rule] = dataAttr[rule] if (attrName == "style") for (var rule in dataAttr) node.style[rule] = dataAttr[rule]
else if (attrName in node) node[attrName] = dataAttr else if (attrName in node) node[attrName] = dataAttr
else node.setAttribute(attrName, dataAttr) else node.setAttribute(attrName, dataAttr)
} //}
} }
return cachedAttrs return cachedAttrs
} }