vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1103 from brlewis/next

Browse source 
Render booleans as empty strings
This commit is contained in:
Leo Horie 2016-06-10 15:26:33 -04:00 • committed by GitHub
commit 8faab54c4c
3 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mithril.js
View file

@ -188,7 +188,7 @@
// value of Console.log in some versions of Firefox (behavior depends on // value of Console.log in some versions of Firefox (behavior depends on
// version) // version)
try { try {
if (data != null && data.toString() != null) return data if (typeof data !== "boolean" && data != null && data.toString() != null) return data
} catch (e) { } catch (e) {
// silently ignore errors // silently ignore errors
} }

18
test/mithril.render.js
View file

@ -57,6 +57,24 @@ describe("m.render()", function () {
expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("") expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("")
}) })
it("renders `null` body to empty string", function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [null]))
expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("")
})
it("renders `true` body to empty string", function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [true]))
expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("")
})
it("renders `false` body to empty string", function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [false]))
expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("")
})
it("uses the W3C URI as default namespace for SVG children", function () { it("uses the W3C URI as default namespace for SVG children", function () {
var root = mock.document.createElement("div") var root = mock.document.createElement("div")
m.render(root, m("svg", [m("g")])) m.render(root, m("svg", [m("g")]))

18
tests/mithril-tests.js
View file

@ -1750,6 +1750,24 @@
return root.childNodes[0].childNodes[0].nodeValue === "" return root.childNodes[0].childNodes[0].nodeValue === ""
}) })
test(function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [null]))
return root.childNodes[0].childNodes[0].nodeValue === ""
})
test(function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [true]))
return root.childNodes[0].childNodes[0].nodeValue === ""
})
test(function () {
var root = mock.document.createElement("div")
m.render(root, m("div", [false]))
return root.childNodes[0].childNodes[0].nodeValue === ""
})
test(function () { test(function () {
var root = mock.document.createElement("div") var root = mock.document.createElement("div")
m.render(root, m("svg", [m("g")])) m.render(root, m("svg", [m("g")]))