vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#544 ignore class: undefined

Browse source
This commit is contained in:
Leo Horie 2015-04-11 20:14:43 -04:00
parent aa541bff79
commit 9e558c199c
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
mithril.js
View file

@ -48,8 +48,6 @@ var m = (function app(window, undefined) {
cell.attrs[pair[1]] = pair[3] || (pair[2] ? "" :true) cell.attrs[pair[1]] = pair[3] || (pair[2] ? "" :true)
} }
} }
if (classes.length > 0) cell.attrs[classAttrName] = classes.join(" ");
var children = hasAttrs ? args.slice(2) : args.slice(1); var children = hasAttrs ? args.slice(2) : args.slice(1);
if (children.length === 1 && type.call(children[0]) === ARRAY) { if (children.length === 1 && type.call(children[0]) === ARRAY) {
@ -60,12 +58,13 @@ var m = (function app(window, undefined) {
} }
for (var attrName in attrs) { for (var attrName in attrs) {
if (attrName === classAttrName) { if (attrName === classAttrName && attrs[attrName] != null && attrs[attrName] !== "") {
var className = cell.attrs[attrName] classes.push(attrs[attrName])
cell.attrs[attrName] = (className && attrs[attrName] ? className + " " : className || "") + attrs[attrName];
} }
else cell.attrs[attrName] = attrs[attrName] else cell.attrs[attrName] = attrs[attrName]
} }
if (classes.length > 0) cell.attrs[classAttrName] = classes.join(" ");
return cell return cell
} }
function build(parentElement, parentTag, parentCache, parentIndex, data, cached, shouldReattach, index, editable, namespace, configs) { function build(parentElement, parentTag, parentCache, parentIndex, data, cached, shouldReattach, index, editable, namespace, configs) {

7
tests/mithril-tests.js
View file

@ -1777,6 +1777,13 @@ function testMithril(mock) {
var after = root.childNodes[0].childNodes[3] var after = root.childNodes[0].childNodes[3]
return before === after return before === after
}) })
test(function() {
var root = mock.document.createElement("div")
var vdom = m("div.a", {class: undefined})
console.log(vdom)
m.render(root, vdom)
return root.childNodes[0].class == "a"
})
//end m.render //end m.render
//m.redraw //m.redraw