vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix null ref when updating component root from null to something

Browse source
This commit is contained in:
Leo Horie 2016-07-08 14:57:10 -04:00
parent a988276e9b
commit abadcfc13a
2 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
render/render.js
View file

@ -243,7 +243,8 @@ module.exports = function($window) {
vnode.instance = Node.normalize(vnode.tag.view.call(vnode.state, vnode))
updateLifecycle(vnode.tag, vnode, hooks, recycling)
if (vnode.instance != null) {
updateNode(parent, old.instance, vnode.instance, hooks, nextSibling, recycling, ns)
if (old.instance == null) insertNode(parent, createNode(vnode.instance, hooks, ns), nextSibling)
else updateNode(parent, old.instance, vnode.instance, hooks, nextSibling, recycling, ns)
vnode.dom = vnode.instance.dom
vnode.domSize = vnode.instance.domSize
}

26
render/tests/test-component.js
View file

@ -54,6 +54,32 @@ o.spec("component", function() {
o(root.firstChild.attributes["id"].nodeValue).equals("c")
o(root.firstChild.firstChild.nodeValue).equals("d")
})
o("updates from null", function() {
var visible = false
var component = {
view: function(vnode) {
return visible ? {tag: "div"} : null
}
}
render(root, [{tag: component}])
visible = true
render(root, [{tag: component}])
o(root.firstChild.nodeName).equals("DIV")
})
o("updates from primitive", function() {
var visible = false
var component = {
view: function(vnode) {
return visible ? {tag: "div"} : false
}
}
render(root, [{tag: component}])
visible = true
render(root, [{tag: component}])
o(root.firstChild.nodeName).equals("DIV")
})
o("removes", function() {
var component = {
view: function(vnode) {