vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add tests for issue 1921 (onremove fires on childrent that don't end up in the instance)

Browse source
This commit is contained in:
Pierre-Yves Gérardy 2017-07-31 11:39:36 +02:00
parent 4aac74eff3
commit acee3d5ecc
1 changed files with 41 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

41
render/tests/test-onremove.js
View file

@ -89,6 +89,7 @@ o.spec("onremove", function() {
o(vnode.dom.onremove).equals(undefined)
o(vnode.dom.attributes["onremove"]).equals(undefined)
o(vnode.events).equals(undefined)
})
o("calls onremove on recycle", function() {
var remove = o.spy()
@ -150,6 +151,46 @@ o.spec("onremove", function() {
o(spy.callCount).equals(1)
})
o("doesn't call onremove on children when the corresponding view returns null (after removing the parent)", function() {
var threw = false
var spy = o.spy()
var parent = createComponent({
view: function() {}
})
var child = createComponent({
view: function() {},
onremove: spy
})
render(root, {tag: parent, children: [child]})
try {
render(root, null)
} catch (e) {
threw = e
}
o(spy.callCount).equals(0)
o(threw).equals(false)
})
o("doesn't call onremove on children when the corresponding view returns null (after removing the children)", function() {
var threw = false
var spy = o.spy()
var parent = createComponent({
view: function() {}
})
var child = createComponent({
view: function() {},
onremove: spy
})
render(root, {tag: parent, children: [child]})
try {
render(root, {tag: parent})
} catch (e) {
threw = true
}
o(spy.callCount).equals(0)
o(threw).equals(false)
})
})
})
})