vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix class removal

Browse source
This commit is contained in:
Leo Horie 2016-09-12 09:45:57 -04:00
parent f0888ac7bd
commit b9244f4c21
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
render/render.js
View file

@ -431,6 +431,7 @@ module.exports = function($window) {
if (old != null) { if (old != null) {
for (var key in old) { for (var key in old) {
if (attrs == null || !(key in attrs)) { if (attrs == null || !(key in attrs)) {
if (key === "className") key = "class"
if (key[0] === "o" && key[1] === "n" && !isLifecycleMethod(key)) updateEvent(vnode, key, undefined) if (key[0] === "o" && key[1] === "n" && !isLifecycleMethod(key)) updateEvent(vnode, key, undefined)
else if (key !== "key") vnode.dom.removeAttribute(key) else if (key !== "key") vnode.dom.removeAttribute(key)
} }

11
render/tests/test-updateElement.js
View file

@ -56,6 +56,17 @@ o.spec("updateElement", function() {
o(updated.dom).equals(root.firstChild) o(updated.dom).equals(root.firstChild)
o("title" in updated.dom.attributes).equals(false) o("title" in updated.dom.attributes).equals(false)
}) })
o("removes class", function() {
var vnode = {tag: "a", attrs: {id: "b", className: "d"}}
var updated = {tag: "a", attrs: {id: "c"}}
render(root, [vnode])
render(root, [updated])
o(updated.dom).equals(vnode.dom)
o(updated.dom).equals(root.firstChild)
o("class" in updated.dom.attributes).equals(false)
})
o("creates style object", function() { o("creates style object", function() {
var vnode = {tag: "a", attrs: {}} var vnode = {tag: "a", attrs: {}}
var updated = {tag: "a", attrs: {style: {backgroundColor: "green"}}} var updated = {tag: "a", attrs: {style: {backgroundColor: "green"}}}