vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove a section that's 1. buggy and 2. controversial [skip ci] (#2265)

Browse source 
See discussion in #2250 and #1986 for more details.
This commit is contained in:
Isiah Meadows 2018-10-28 17:00:47 -04:00 • committed by GitHub
parent 0e6223da73
commit b9c3c6c9c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

30
docs/components.md
View file

@ -363,36 +363,6 @@ This way, the `Auth` module is now the source of truth for auth-related state, a
As a bonus, notice that we no longer need to use `.bind` to keep a reference to the state for the component's event handlers.
#### Avoid restrictive interfaces
Try to keep component interfaces generic - using `attrs` and `children` directly - unless the component requires special logic to operate on input.
In the example below, the `button` configuration is severely limited: it does not support any events other than `onclick`, it's not styleable and it only accepts text as children (but not elements, fragments or trusted HTML).
```javascript
// AVOID
var RestrictiveComponent = {
view: function(vnode) {
return m("button", {onclick: vnode.attrs.onclick}, [
"Click to " + vnode.attrs.text
])
}
}
```
If the required attributes are equivalent to generic DOM attributes, it's preferable to allow passing through parameters to a component's root node.
```javascript
// PREFER
var FlexibleComponent = {
view: function(vnode) {
return m("button", vnode.attrs, [
"Click to ", vnode.children
])
}
}
```
#### Don't manipulate `children`
If a component is opinionated in how it applies attributes or children, you should switch to using custom attributes.