test: enable danger & tweak messaging
This commit is contained in:
parent
a7849a67ca
commit
bee11087af
2 changed files with 7 additions and 4 deletions
|
|
@ -15,10 +15,11 @@ install:
|
|||
- npm install
|
||||
- npm install --no-save @alrra/travis-scripts@^3.0.1 gh-pages@^0.12.0
|
||||
|
||||
# Create bundles before running tests so they're always up-to-date
|
||||
# Pass -save to build-min so it'll update the readme as well
|
||||
# Run danger, build bundles (so they're always up to date)
|
||||
before_script:
|
||||
- npx danger run
|
||||
- npm run build-browser
|
||||
# Pass -save so it'll update the readme as well
|
||||
- npm run build-min -- -save
|
||||
|
||||
# Run tests, lint, and then check for perf regressions
|
||||
|
|
|
|||
|
|
@ -35,7 +35,9 @@ if(danger.github.pr.base.ref !== "next") {
|
|||
|
||||
// Any non-test JS changes should probably have a change-log entry
|
||||
if(appfiles.length && !changelog) {
|
||||
warn(`Please include a ${link("docs/change-log.md", "changelog")} entry.`)
|
||||
warn(dedent(`
|
||||
Please add an entry to ${link("docs/change-log.md")}.
|
||||
`))
|
||||
}
|
||||
|
||||
// Call out if `o.only(...)` was left in
|
||||
|
|
@ -47,7 +49,7 @@ jsfiles
|
|||
|
||||
locs.forEach((loc) =>
|
||||
fail(dedent(`
|
||||
${link(file, `#L${loc.line}`)} is preventing tests from running.
|
||||
Please remove the \`o.only\` from ${link(file, `#L${loc.line}`)}.
|
||||
<pre lang="javascript">
|
||||
${pinpoint(code, {line: loc.line, column : loc.cursor})}
|
||||
</pre>
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue