vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Isolate m.prop() and m.deferred() implementations (mostly)

Browse source 
This mostly isolates the implementations for both of these. Now, everything
here calls the method itself, not any of the external methods.

Few driveby fixes as well:

1. Git now ignores archive/ again (it's a build artifact, and can be removed
   when updating `master`)
2. Since I had to rewrite most of the Deferred implementation, the new version
   passes one of the skipped tests, so it is now enabled.
This commit is contained in:
impinball 2015-11-20 00:55:04 -05:00
parent edc5dca238
commit d7ef127be2
6 changed files with 170 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/mithril.deferred.js
View file

@ -117,8 +117,7 @@ describe("m.deferred()", function () {
expect(value2()).to.be.an("error")
})
// FIXME: this is a bug.
xit("synchronously throws subclasses of Errors on creation", function () {
it("synchronously throws subclasses of Errors on creation", function () {
expect(function () {
m.deferred().reject(new TypeError())
}).to.throw()

6
test/mithril.prop.js
View file

@ -53,12 +53,14 @@ describe("m.prop()", function () {
it("returns a thenable when wrapping a Mithril promise", function () {
var defer = m.deferred()
var prop = m.prop(defer.promise).then(function () {
var prop = m.prop(defer.promise)
var promise = prop.then(function () {
return "test2"
})
defer.resolve("test")
expect(prop()).to.equal("test2")
expect(promise()).to.equal("test2")
})
})