vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Trying to fix #1916 (#1918)

Browse source 
* Trying to fix #1916

* Remove test for rendering select options. Add back after resolving issue #1978.

* Add #1916 fix to change log.

* Revert "Remove test for rendering select options. Add back after resolving issue #1978."

This reverts commit d4c1be7c2319adf744f78ca787485f52be869208.

* Comment on why failing test for #1916 is commented out.
This commit is contained in:
robinchew 2017-11-01 03:37:51 +08:00 • committed by Pierre-Yves Gérardy
parent f22d7d4ca9
commit db2a12dec9
3 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
render/tests/test-attributes.js
View file

@ -462,6 +462,19 @@ o.spec("attributes", function() {
{tag:"option", attrs: {value: ""}}
]}
}
/* FIXME
This incomplete test is meant for testing #1916.
However it cannot be completed until #1978 is addressed
which is a lack a working select.selected / option.selected
attribute. Ask isiahmeadows.
o("render select options", function() {
var select = {tag: "select", selectedIndex: 0, children: [
{tag:"option", attrs: {value: "1", selected: ""}}
]}
render(root, select)
})
*/
o("can be set as text", function() {
var a = makeSelect()
var b = makeSelect("2")