vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve attrs setting performance

Browse source 
before:

> mutate styles/properties x 7,999 ops/sec ±10.87% (46 runs sampled)

after:

> mutate styles/properties x 16,104 ops/sec ±4.36% (66 runs sampled)
This commit is contained in:
Pierre-Yves Gerardy 2017-05-29 23:27:03 +02:00 • committed by Pierre-Yves Gérardy
parent 4197cf0ae1
commit dc15acd791
1 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
render/render.js
View file

@ -692,10 +692,9 @@ module.exports = function($window) {
return
}
if ((old === value && !isFormAttribute(vnode, key)) && typeof value !== "object" || value === undefined) return
var element = vnode.dom
if (key.slice(0, 6) === "xlink:") element.setAttributeNS("http://www.w3.org/1999/xlink", key, value)
else if (key === "style") updateStyle(element, old, value)
else if (key in element && !isAttribute(key) && ns === undefined && !isCustomElement(vnode)) {
if (key.slice(0, 6) === "xlink:") vnode.dom.setAttributeNS("http://www.w3.org/1999/xlink", key, value)
else if (key === "style") updateStyle(vnode.dom, old, value)
else if (key in vnode.dom && !isAttribute(key) && ns === undefined && !isCustomElement(vnode)) {
if (key === "value") {
var normalized = "" + value // eslint-disable-line no-implicit-coercion
//setting input[value] to same value by typing on focused element moves cursor to end in Chrome
@ -713,17 +712,17 @@ module.exports = function($window) {
}
// If you assign an input type that is not supported by IE 11 with an assignment expression, an error will occur.
if (vnode.tag === "input" && key === "type") {
element.setAttribute(key, value)
vnode.dom.setAttribute(key, value)
return
}
element[key] = value
vnode.dom[key] = value
}
else {
if (typeof value === "boolean") {
if (value) element.setAttribute(key, "")
else element.removeAttribute(key)
if (value) vnode.dom.setAttribute(key, "")
else vnode.dom.removeAttribute(key)
}
else element.setAttribute(key === "className" ? "class" : key, value)
else vnode.dom.setAttribute(key === "className" ? "class" : key, value)
}
}
function removeAttr(vnode, key, old, ns) {