vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#1039 ignore url interpolations without mapped values

Browse source
This commit is contained in:
Leo Horie 2016-05-06 11:49:00 -04:00
parent db17958f0b
commit dee64503db
4 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mithril.js
View file

@ -2113,7 +2113,7 @@
if (data) { if (data) {
url = url.replace(/:[a-z]\w+/gi, function (token){ url = url.replace(/:[a-z]\w+/gi, function (token){
var key = token.slice(1) var key = token.slice(1)
var value = data[key] var value = data[key] || token
delete data[key] delete data[key]
return value return value
}) })

2
mithril.min.js vendored
View file

File diff suppressed because one or more lines are too long

2
mithril.min.js.map
View file

File diff suppressed because one or more lines are too long

6
test/mithril.request.js
View file

@ -195,6 +195,12 @@ describe("m.request()", function () {
expect(prop().url).to.equal("/test") expect(prop().url).to.equal("/test")
}) })
it("ignores interpolations without data", function () { // eslint-disable-line
var prop = m.request({method: "GET", url: "/test:notfound", data: {foo: 1}})
resolve()
expect(prop().url).to.equal("/test:notfound?foo=1")
})
it("appends children in query strings to `url` from `data` for `GET`", function () { // eslint-disable-line it("appends children in query strings to `url` from `data` for `GET`", function () { // eslint-disable-line
var prop = m.request({method: "GET", url: "test", data: {foo: [1, 2]}}) var prop = m.request({method: "GET", url: "test", data: {foo: [1, 2]}})
resolve() resolve()