vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#380 empty value attr in option should show up

Browse source
This commit is contained in:
Leo Horie 2014-12-08 11:47:27 -05:00
parent d05b903024
commit e453ec7ce3
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mithril.js
View file

@ -346,7 +346,7 @@ var m = (function app(window, undefined) {
//- when using CSS selectors (e.g. `m("[style='']")`), style is used as a string, but it's an object in js
else if (attrName in node && !(attrName === "list" || attrName === "style" || attrName === "form" || attrName === "type")) {
//#348 don't set the value if not needed otherwise cursor placement breaks in Chrome
if (node[attrName] !== dataAttr) node[attrName] = dataAttr
if (attrName != "input" || node[attrName] !== dataAttr) node[attrName] = dataAttr
}
else node.setAttribute(attrName, dataAttr)
}

7
tests/e2e/tests.js
View file

@ -409,8 +409,13 @@ test("mixing trusted content w/ td", function() {
equal(dummyEl.childNodes[1].nodeName, "I")
})
test("", function() {
test("0 should not be treated as empty string", function() {
m.render(dummyEl, m("input", {value: ""}))
m.render(dummyEl, m("input", {value: 0}))
equal(dummyEl.childNodes[0].value, "0")
})
test("empty value in <option> should show as attribute", function() {
m.render(dummyEl, m("select", m("option", {value: ""}, "aaa")))
equal(dummyEl.childNodes[0].innerHTML, '<option value="">aaa</option>')
})