vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Store normalized vnodes in the dom element. Add render tests. (#2266)

Browse source 
* Store normalized vnodes in the dom element. Add render tests.

* Add entry to change-log
This commit is contained in:
spacejack 2018-10-28 17:17:24 -04:00 • committed by Isiah Meadows
parent b9c3c6c9c8
commit ea0ce7f762
3 changed files with 29 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
render/render.js
View file

@ -865,8 +865,8 @@ module.exports = function($window) {
// First time rendering into a node clears it out
if (dom.vnodes == null) dom.textContent = ""
if (!Array.isArray(vnodes)) vnodes = [vnodes]
updateNodes(dom, dom.vnodes, Vnode.normalizeChildren(vnodes), hooks, null, namespace === "http://www.w3.org/1999/xhtml" ? undefined : namespace)
vnodes = Vnode.normalizeChildren(Array.isArray(vnodes) ? vnodes : [vnodes])
updateNodes(dom, dom.vnodes, vnodes, hooks, null, namespace === "http://www.w3.org/1999/xhtml" ? undefined : namespace)
dom.vnodes = vnodes
// document.activeElement can return null in IE https://developer.mozilla.org/en-US/docs/Web/API/Document/activeElement
if (active != null && $doc.activeElement !== active && typeof active.focus === "function") active.focus()

26
render/tests/test-render.js
View file

@ -12,6 +12,32 @@ o.spec("render", function() {
render = vdom($window).render
})
o("renders plain text", function() {
render(root, "a")
o(root.childNodes.length).equals(1)
o(root.childNodes[0].nodeValue).equals("a")
})
o("updates plain text", function() {
render(root, "a")
render(root, "b")
o(root.childNodes.length).equals(1)
o(root.childNodes[0].nodeValue).equals("b")
})
o("renders a number", function() {
render(root, 1)
o(root.childNodes.length).equals(1)
o(root.childNodes[0].nodeValue).equals("1")
})
o("updates a number", function() {
render(root, 1)
render(root, 2)
o(root.childNodes.length).equals(1)
o(root.childNodes[0].nodeValue).equals("2")
})
o("overwrites existing content", function() {
var vnodes = []