vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix node insertion bug when using document as root

Browse source
This commit is contained in:
Leo Horie 2014-07-10 08:51:31 -04:00
parent ccde633e92
commit eda32fef47
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/routing.md
View file

@ -41,13 +41,13 @@ var dashboard = {
} }
} }
//setup routes to start w/ the `#` symbol
m.route.mode = "hash";
//define a route //define a route
m.route(document.body, "/dashboard/johndoe", { m.route(document.body, "/dashboard/johndoe", {
"/dashboard/:userID": dashboard "/dashboard/:userID": dashboard
}); });
//setup routes to start w/ the `#` symbol
m.route.mode = "hash";
``` ```
This redirects to the URL `http://server/#/dashboard/johndoe` and yields: This redirects to the URL `http://server/#/dashboard/johndoe` and yields:

3
mithril.js
View file

@ -287,9 +287,10 @@ Mithril = m = new function app(window) {
if (html === undefined) html = window.document.createElement("html") if (html === undefined) html = window.document.createElement("html")
if (node.nodeName == "HTML") html = node if (node.nodeName == "HTML") html = node
else html.appendChild(node) else html.appendChild(node)
if (window.document.documentElement !== html) { if (window.document.documentElement && window.document.documentElement !== html) {
window.document.replaceChild(html, window.document.documentElement) window.document.replaceChild(html, window.document.documentElement)
} }
else window.document.appendChild(html)
}, },
insertBefore: function(node) { insertBefore: function(node) {
this.appendChild(node) this.appendChild(node)