From f9e51636d8d5be06b1d74254a7bb2b5d9b9a7d67 Mon Sep 17 00:00:00 2001 From: Barney Carroll Date: Sun, 2 May 2021 15:09:47 +0100 Subject: [PATCH] vnode.attrs is never null --- render/hyperscript.js | 2 +- render/tests/test-hyperscript.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/render/hyperscript.js b/render/hyperscript.js index 5554aeec..26ff753e 100644 --- a/render/hyperscript.js +++ b/render/hyperscript.js @@ -36,7 +36,7 @@ function execSelector(state, vnode) { var className = hasClass ? attrs.class : attrs.className vnode.tag = state.tag - vnode.attrs = null + vnode.attrs = {} if (!isEmpty(state.attrs) && !isEmpty(attrs)) { var newAttrs = {} diff --git a/render/tests/test-hyperscript.js b/render/tests/test-hyperscript.js index 39266a80..59751f44 100644 --- a/render/tests/test-hyperscript.js +++ b/render/tests/test-hyperscript.js @@ -271,7 +271,7 @@ o.spec("hyperscript", function() { var vnode = m("div", {key:"a"}) o(vnode.tag).equals("div") - o(vnode.attrs).equals(null) + o(vnode.attrs).deepEquals({}) o(vnode.key).equals("a") }) o("handles many attrs", function() { @@ -343,7 +343,7 @@ o.spec("hyperscript", function() { var vnode = m("custom-element", {key:"a"}) o(vnode.tag).equals("custom-element") - o(vnode.attrs).equals(null) + o(vnode.attrs).deepEquals({}) o(vnode.key).equals("a") }) o("handles many attrs", function() { @@ -551,20 +551,20 @@ o.spec("hyperscript", function() { o("handles children without attr", function() { var vnode = m("div", [m("i"), m("s")]) - o(vnode.attrs).equals(null) + o(vnode.attrs).deepEquals({}) o(vnode.children[0].tag).equals("i") o(vnode.children[1].tag).equals("s") }) o("handles child without attr unwrapped", function() { var vnode = m("div", m("i")) - o(vnode.attrs).equals(null) + o(vnode.attrs).deepEquals({}) o(vnode.children[0].tag).equals("i") }) o("handles children without attr unwrapped", function() { var vnode = m("div", m("i"), m("s")) - o(vnode.attrs).equals(null) + o(vnode.attrs).deepEquals({}) o(vnode.children[0].tag).equals("i") o(vnode.children[1].tag).equals("s") })