vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tests: enable tests for #1638

Browse source
This commit is contained in:
Pierre-Yves Gerardy 2017-02-19 22:57:31 +01:00
parent 1dd5fe3101
commit fc038f9d85
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
render/tests/test-component.js
View file

@ -747,8 +747,7 @@ o.spec("component", function() {
] ]
hooks.forEach(function(hook) { hooks.forEach(function(hook) {
attrs[hook] = o.spy(function(vnode){ attrs[hook] = o.spy(function(vnode){
// #1638, the assertion passes for `oninit` because both values are wrong. o(this).equals(vnode.state)(hook)
if (hook !== 'oncreate') o(this).equals(vnode.state)(hook)
}) })
methods[hook] = o.spy(function(vnode){ methods[hook] = o.spy(function(vnode){
o(this).equals(vnode.state) o(this).equals(vnode.state)
@ -762,8 +761,7 @@ o.spec("component", function() {
render(root, []) render(root, [])
hooks.forEach(function(hook) { hooks.forEach(function(hook) {
// #1638 o(attrs[hook].this).equals(methods.view.this)(hook)
if (hook !== "oninit" && hook !== 'oncreate') o(attrs[hook].this).equals(methods.view.this)(hook)
o(methods[hook].this).equals(methods.view.this)(hook) o(methods[hook].this).equals(methods.view.this)(hook)
}) })
@ -848,8 +846,7 @@ o.spec("component", function() {
var oninit = o.spy() var oninit = o.spy()
var component = o.spy(function(vnode){ var component = o.spy(function(vnode){
o(vnode.state).equals(null) o(vnode.state).equals(null)
// #1638 o(oninit.callCount).equals(0)
// o(oninit.callCount).equals(0)
}) })
var view = o.spy(function(){ var view = o.spy(function(){
o(this instanceof component).equals(true) o(this instanceof component).equals(true)
@ -877,8 +874,7 @@ o.spec("component", function() {
}) })
var component = o.spy(function(vnode) { var component = o.spy(function(vnode) {
o(vnode.state).equals(null) o(vnode.state).equals(null)
// #1638 o(oninit.callCount).equals(0)
// o(oninit.callCount).equals(0)
return state = { return state = {
view: view view: view
} }