vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

allow dom level 1 events to be removed #1385

Browse source
This commit is contained in:
Leo Horie 2016-11-04 12:33:36 -04:00
parent bc0a75a6a2
commit ff7ce37476
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/render.js
View file

@ -500,7 +500,7 @@ module.exports = function($window) {
if (typeof onevent === "function") onevent.call(element, e) if (typeof onevent === "function") onevent.call(element, e)
return result return result
} }
if (key in element) element[key] = callback if (key in element) element[key] = typeof value === "function" ? callback : null
else { else {
var eventName = key.slice(2) var eventName = key.slice(2)
if (vnode.events === undefined) vnode.events = {} if (vnode.events === undefined) vnode.events = {}

1
test-utils/domMock.js
View file

@ -237,6 +237,7 @@ module.exports = function() {
} }
if (typeof this["on" + e.type] === "function" && !isModernEvent(e.type)) this["on" + e.type](e) if (typeof this["on" + e.type] === "function" && !isModernEvent(e.type)) this["on" + e.type](e)
}, },
onclick: null,
} }
if (element.nodeName === "A") { if (element.nodeName === "A") {

3
test-utils/tests/test-domMock.js
View file

@ -559,6 +559,9 @@ o.spec("domMock", function() {
$document.body.removeChild(div) $document.body.removeChild(div)
}) })
o("has onclick", function() {
o("onclick" in div).equals(true)
})
o("addEventListener works", function() { o("addEventListener works", function() {
div.addEventListener("click", spy, false) div.addEventListener("click", spy, false)
div.dispatchEvent(e) div.dispatchEvent(e)