Details: 1. All tests now live in `test`. All test dependencies that aren't from npm live in `test-deps`. 2. The QUnit tests are gone, as well as their dependencies. Half of them duplicated existing tests, and some of them depended on the real DOM to properly test. 3. All tests are now using Mocha to run the tests, Chai for assertions, and Sinon and Sinon Chai for testing some callbacks. 4. Tests are run through mocha-phantomjs. If you want to run just the tests, run `grunt mocha_phantomjs` or fire up a server in the root and open `http://localhost:<port>/test/index.html`, e.g. `python3 -m http.server`. 5. The linter I chose is ESLint. It is relatively easy to configure, but with a lot of flexibility. The rules I chose mostly were in tune to the style the project was already using. I'm not including a style guide in this commit, but one will likely come. You can check out the `.eslintrc` in the root and in `test/` for the two configs. The `.eslintignore` includes a TODO for `mithril.js` itself targeted at me, in the root. Other info: - As a drive-by fix, I fixed line endings on a few of the files. - I also took care of a few other files and linted them as I went: - `Gruntfile.js` - `test/input-cursor.html` (was in `tests/`) - `test/svg.html` (was in `tests/`) - `docs/layout/tools/template-converter.html` - `docs/layout/tools/template-converter.js` I didn't test the template converter after linting it, because it needs further scrutiny to ensure it works with the latest version of Mithril. I know the API has changed a little, which is why I want to be sure. - I simplified the `.travis.yml` file because none of the tests are run directly through Node anymore. They are always run in a browser of some kind. Hopefully, this turned out all right...
220 lines
4.8 KiB
JavaScript
220 lines
4.8 KiB
JavaScript
describe("m.redraw()", function () {
|
|
"use strict"
|
|
|
|
beforeEach(function () {
|
|
mock.requestAnimationFrame.$resolve()
|
|
})
|
|
|
|
it("exists", function () {
|
|
expect(m.redraw).to.be.a("function")
|
|
})
|
|
|
|
it("correctly renders a property if the controller value changes", function () { // eslint-disable-line
|
|
var ctx
|
|
var root = mock.document.createElement("div")
|
|
|
|
m.mount(root, {
|
|
controller: function () { ctx = this }, // eslint-disable-line
|
|
view: function (ctrl) { return ctrl.value }
|
|
})
|
|
|
|
mock.requestAnimationFrame.$resolve()
|
|
|
|
var valueBefore = root.childNodes[0].nodeValue
|
|
ctx.value = "foo"
|
|
|
|
m.redraw()
|
|
mock.requestAnimationFrame.$resolve()
|
|
|
|
expect(valueBefore).to.equal("")
|
|
expect(root.childNodes[0].nodeValue).to.equal("foo")
|
|
})
|
|
|
|
it("runs unnecessary redraws asynchronously", function () {
|
|
var root = mock.document.createElement("div")
|
|
var view = sinon.spy()
|
|
|
|
m.mount(root, {
|
|
controller: function () {},
|
|
view: view
|
|
})
|
|
mock.requestAnimationFrame.$resolve() // teardown
|
|
m.redraw()
|
|
|
|
// These should run asynchronously
|
|
m.redraw()
|
|
m.redraw()
|
|
m.redraw()
|
|
mock.requestAnimationFrame.$resolve() // teardown
|
|
|
|
expect(view).to.be.calledThrice
|
|
})
|
|
|
|
it("runs unnecessary forced redraws asynchronously", function () {
|
|
var root = mock.document.createElement("div")
|
|
var view = sinon.spy()
|
|
m.mount(root, {
|
|
controller: function () {},
|
|
view: view
|
|
})
|
|
mock.requestAnimationFrame.$resolve() // teardown
|
|
m.redraw(true)
|
|
|
|
// These should run asynchronously
|
|
m.redraw(true)
|
|
m.redraw(true)
|
|
m.redraw(true)
|
|
mock.requestAnimationFrame.$resolve() // teardown
|
|
|
|
expect(view).to.have.callCount(5)
|
|
})
|
|
|
|
context("m.redraw.strategy()", function () {
|
|
// Use this instead of m.route() unless you have to call m.route and do
|
|
// something else in the same frame.
|
|
function route() {
|
|
var res = m.route.apply(null, arguments)
|
|
mock.requestAnimationFrame.$resolve()
|
|
return res
|
|
}
|
|
|
|
// Little helper utility
|
|
function noop() {}
|
|
|
|
// Use this if all you need to do is render a view (i.e. a pure
|
|
// component).
|
|
function pure(view) {
|
|
return {
|
|
controller: noop,
|
|
view: view
|
|
}
|
|
}
|
|
|
|
// Use these instead of `it` and `xit` in this set of tests if you need
|
|
// a root element.
|
|
var dit = makeIt(it)
|
|
|
|
// Wraps the `it` function for dependency injection that doesn't require
|
|
// `this`
|
|
/* eslint-disable no-invalid-this */
|
|
function makeIt(it) {
|
|
return function (name, callback) {
|
|
return it(name, function () {
|
|
var args = [this.root]
|
|
for (var i = 0; i < arguments.length; i++) {
|
|
args.push(arguments[i])
|
|
}
|
|
callback.apply(null, args)
|
|
})
|
|
}
|
|
}
|
|
|
|
beforeEach(function () {
|
|
mock.requestAnimationFrame.$resolve()
|
|
mock.location.search = "?"
|
|
m.route.mode = "search"
|
|
this.root = mock.document.createElement("div")
|
|
})
|
|
|
|
afterEach(function () {
|
|
m.mount(this.root, null)
|
|
})
|
|
/* eslint-enable no-invalid-this */
|
|
|
|
it("exists", function () {
|
|
expect(m.redraw.strategy).to.be.a("function")
|
|
})
|
|
|
|
dit("works with \"all\"", function (root) {
|
|
var strategy
|
|
|
|
route(root, "/foo1", {
|
|
"/foo1": {
|
|
controller: function () {
|
|
strategy = m.redraw.strategy()
|
|
m.redraw.strategy("none")
|
|
},
|
|
view: function () {
|
|
return m("div")
|
|
}
|
|
}
|
|
})
|
|
|
|
expect(strategy).to.equal("all")
|
|
expect(root.childNodes).to.be.empty
|
|
})
|
|
|
|
dit("works with \"redraw\"", function (root) {
|
|
var count = 0
|
|
var strategy
|
|
function config(el, init) {
|
|
if (!init) count++
|
|
}
|
|
|
|
route(root, "/foo1", {
|
|
"/foo1": pure(function () {
|
|
return m("div", {config: config})
|
|
}),
|
|
"/bar1": {
|
|
controller: function () {
|
|
strategy = m.redraw.strategy()
|
|
m.redraw.strategy("redraw")
|
|
},
|
|
view: function () {
|
|
return m("div", {config: config})
|
|
}
|
|
}
|
|
})
|
|
|
|
route("/bar1")
|
|
|
|
expect(strategy).to.equal("all")
|
|
expect(count).to.equal(1)
|
|
})
|
|
|
|
dit("works with \"diff\"", function (root) {
|
|
var strategy
|
|
m.route(root, "/foo1", {
|
|
"/foo1": {
|
|
controller: function () { this.number = 1 },
|
|
view: function (ctrl) {
|
|
return m("div", {
|
|
onclick: function () {
|
|
strategy = m.redraw.strategy()
|
|
ctrl.number++
|
|
m.redraw.strategy("none")
|
|
}
|
|
}, ctrl.number)
|
|
}
|
|
}
|
|
})
|
|
root.childNodes[0].onclick({})
|
|
mock.requestAnimationFrame.$resolve()
|
|
|
|
expect(strategy).to.equal("diff")
|
|
expect(root.childNodes[0].childNodes[0].nodeValue).to.equal("1")
|
|
})
|
|
|
|
dit("recreates the component when \"all\"", function (root) {
|
|
var count = 0
|
|
function config(el, init) {
|
|
if (!init) count++
|
|
}
|
|
|
|
m.route(root, "/foo1", {
|
|
"/foo1": pure(function () {
|
|
return m("div", {
|
|
config: config,
|
|
onclick: function () {
|
|
m.redraw.strategy("all")
|
|
}
|
|
})
|
|
})
|
|
})
|
|
root.childNodes[0].onclick({})
|
|
mock.requestAnimationFrame.$resolve()
|
|
|
|
expect(count).to.equal(2)
|
|
})
|
|
})
|
|
})
|