* De-servicify router (mostly) Still uses the redraw service, but it no longer has an intermediate service of its own. Also, did a *lot* of test deduplication in this. About 30-40% of the router service tests were already tested on the main router API instance itself. Bundle size decreased from 9560 to 9548 bytes min+gzip. * Merge `m.mount` + `m.redraw`, update router Simplifies the router and redraw mechanism, and makes it much easier to keep predictable. Bundle size down to 9433 bytes min+gzip, docs updated accordingly. * Make `mithril/render` just return the `m.render` function directly. * Deservicify `m.render`, revise `m.route` - You now have to use `mithril/render/render` directly if you want an implicit redraw function. (This will likely be going away in v3.) - Revise `m.route` to only `key` components * Add `redraw` to `m.render`, deservicify requests * Test error logging * Update docs + changelog [skip ci]
219 lines
6.1 KiB
JavaScript
219 lines
6.1 KiB
JavaScript
"use strict"
|
|
|
|
var o = require("../../ospec/ospec")
|
|
var components = require("../../test-utils/components")
|
|
var domMock = require("../../test-utils/domMock")
|
|
var vdom = require("../../render/render")
|
|
var m = require("../../render/hyperscript")
|
|
|
|
o.spec("onremove", function() {
|
|
var $window, root, render
|
|
o.beforeEach(function() {
|
|
$window = domMock()
|
|
root = $window.document.createElement("div")
|
|
render = vdom($window)
|
|
})
|
|
|
|
o("does not call onremove when creating", function() {
|
|
var create = o.spy()
|
|
var update = o.spy()
|
|
var vnode = {tag: "div", attrs: {onremove: create}}
|
|
var updated = {tag: "div", attrs: {onremove: update}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(create.callCount).equals(0)
|
|
})
|
|
o("does not call onremove when updating", function() {
|
|
var create = o.spy()
|
|
var update = o.spy()
|
|
var vnode = {tag: "div", attrs: {onremove: create}}
|
|
var updated = {tag: "div", attrs: {onremove: update}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(create.callCount).equals(0)
|
|
o(update.callCount).equals(0)
|
|
})
|
|
o("calls onremove when removing element", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "div", attrs: {onremove: remove}, state: {}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
o(remove.callCount).equals(1)
|
|
o(remove.this).equals(vnode.state)
|
|
o(remove.args[0]).equals(vnode)
|
|
})
|
|
o("calls onremove when removing text", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "#", attrs: {onremove: remove}, children: "a", state: {}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
o(remove.callCount).equals(1)
|
|
o(remove.this).equals(vnode.state)
|
|
o(remove.args[0]).equals(vnode)
|
|
})
|
|
o("calls onremove when removing fragment", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "[", attrs: {onremove: remove}, children: [], state: {}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
o(remove.callCount).equals(1)
|
|
o(remove.this).equals(vnode.state)
|
|
o(remove.args[0]).equals(vnode)
|
|
})
|
|
o("calls onremove when removing html", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "<", attrs: {onremove: remove}, children: "a", state: {}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
o(remove.callCount).equals(1)
|
|
o(remove.this).equals(vnode.state)
|
|
o(remove.args[0]).equals(vnode)
|
|
})
|
|
o("does not set onremove as an event handler", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "div", attrs: {onremove: remove}, children: []}
|
|
|
|
render(root, [vnode])
|
|
|
|
o(vnode.dom.onremove).equals(undefined)
|
|
o(vnode.dom.attributes["onremove"]).equals(undefined)
|
|
o(vnode.events).equals(undefined)
|
|
})
|
|
o("calls onremove on keyed nodes", function() {
|
|
var remove = o.spy()
|
|
var vnodes = [{tag: "div", key: 1}]
|
|
var temp = [{tag: "div", key: 2, attrs: {onremove: remove}}]
|
|
var updated = [{tag: "div", key: 1}]
|
|
|
|
render(root, vnodes)
|
|
render(root, temp)
|
|
render(root, updated)
|
|
|
|
o(vnodes[0].dom).notEquals(updated[0].dom) // this used to be a recycling pool test
|
|
o(remove.callCount).equals(1)
|
|
})
|
|
o("does not recycle when there's an onremove", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "div", key: 1, attrs: {onremove: remove}}
|
|
var updated = {tag: "div", key: 1, attrs: {onremove: remove}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
render(root, [updated])
|
|
|
|
o(vnode.dom).notEquals(updated.dom)
|
|
})
|
|
components.forEach(function(cmp){
|
|
o.spec(cmp.kind, function(){
|
|
var createComponent = cmp.create
|
|
|
|
o("calls onremove on nested component", function() {
|
|
var spy = o.spy()
|
|
var comp = createComponent({
|
|
view: function() {return m(outer)}
|
|
})
|
|
var outer = createComponent({
|
|
view: function() {return m(inner)}
|
|
})
|
|
var inner = createComponent({
|
|
onremove: spy,
|
|
view: function() {return m("div")}
|
|
})
|
|
render(root, {tag: comp})
|
|
render(root, null)
|
|
|
|
o(spy.callCount).equals(1)
|
|
})
|
|
o("calls onremove on nested component child", function() {
|
|
var spy = o.spy()
|
|
var comp = createComponent({
|
|
view: function() {return m(outer)}
|
|
})
|
|
var outer = createComponent({
|
|
view: function() {return m(inner, m("a", {onremove: spy}))}
|
|
})
|
|
var inner = createComponent({
|
|
view: function(vnode) {return m("div", vnode.children)}
|
|
})
|
|
render(root, {tag: comp})
|
|
render(root, null)
|
|
|
|
o(spy.callCount).equals(1)
|
|
})
|
|
o("doesn't call onremove on children when the corresponding view returns null (after removing the parent)", function() {
|
|
var threw = false
|
|
var spy = o.spy()
|
|
var parent = createComponent({
|
|
view: function() {}
|
|
})
|
|
var child = createComponent({
|
|
view: function() {},
|
|
onremove: spy
|
|
})
|
|
render(root, {tag: parent, children: [child]})
|
|
try {
|
|
render(root, null)
|
|
} catch (e) {
|
|
threw = e
|
|
}
|
|
|
|
o(spy.callCount).equals(0)
|
|
o(threw).equals(false)
|
|
})
|
|
o("doesn't call onremove on children when the corresponding view returns null (after removing the children)", function() {
|
|
var threw = false
|
|
var spy = o.spy()
|
|
var parent = createComponent({
|
|
view: function() {}
|
|
})
|
|
var child = createComponent({
|
|
view: function() {},
|
|
onremove: spy
|
|
})
|
|
render(root, {tag: parent, children: [child]})
|
|
try {
|
|
render(root, {tag: parent})
|
|
} catch (e) {
|
|
threw = true
|
|
}
|
|
|
|
o(spy.callCount).equals(0)
|
|
o(threw).equals(false)
|
|
})
|
|
o("onremove doesn't fire on nodes that go from pool to pool (#1990)", function() {
|
|
var onremove = o.spy();
|
|
|
|
render(root, [m("div", m("div")), m("div", m("div", {onremove: onremove}))]);
|
|
render(root, [m("div", m("div"))]);
|
|
render(root, []);
|
|
|
|
o(onremove.callCount).equals(1)
|
|
})
|
|
o("doesn't fire when removing the children of a node that's brought back from the pool (#1991 part 2)", function() {
|
|
var onremove = o.spy()
|
|
var vnode = {tag: "div", key: 1, children: [{tag: "div", attrs: {onremove: onremove}}]}
|
|
var temp = {tag: "div", key: 2}
|
|
var updated = {tag: "div", key: 1, children: [{tag: "p"}]}
|
|
|
|
render(root, [vnode])
|
|
render(root, [temp])
|
|
render(root, [updated])
|
|
|
|
o(vnode.dom).notEquals(updated.dom) // this used to be a recycling pool test
|
|
o(onremove.callCount).equals(1)
|
|
})
|
|
})
|
|
})
|
|
})
|