db2a12dec9
* Trying to fix #1916 * Remove test for rendering select options. Add back after resolving issue #1978. * Add #1916 fix to change log. * Revert "Remove test for rendering select options. Add back after resolving issue #1978." This reverts commit d4c1be7c2319adf744f78ca787485f52be869208. * Comment on why failing test for #1916 is commented out.
642 lines
15 KiB
JavaScript
642 lines
15 KiB
JavaScript
"use strict"
|
|
|
|
var o = require("../../ospec/ospec")
|
|
var domMock = require("../../test-utils/domMock")
|
|
var vdom = require("../../render/render")
|
|
|
|
o.spec("attributes", function() {
|
|
var $window, root, render
|
|
o.beforeEach(function() {
|
|
$window = domMock()
|
|
root = $window.document.body
|
|
render = vdom($window).render
|
|
})
|
|
o.spec("basics", function() {
|
|
o("works (create/update/remove)", function() {
|
|
|
|
var a = {tag: "div", attrs: {}}
|
|
var b = {tag: "div", attrs: {id: "test"}}
|
|
var c = {tag: "div", attrs: {}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.hasAttribute("id")).equals(false)
|
|
|
|
render(root, [b]);
|
|
|
|
o(b.dom.getAttribute("id")).equals("test")
|
|
|
|
render(root, [c]);
|
|
|
|
o(c.dom.hasAttribute("id")).equals(false)
|
|
})
|
|
o("undefined attr is equivalent to a lack of attr", function() {
|
|
var a = {tag: "div", attrs: {id: undefined}}
|
|
var b = {tag: "div", attrs: {id: "test"}}
|
|
var c = {tag: "div", attrs: {id: undefined}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.hasAttribute("id")).equals(false)
|
|
|
|
render(root, [b]);
|
|
|
|
o(b.dom.hasAttribute("id")).equals(true)
|
|
o(b.dom.getAttribute("id")).equals("test")
|
|
|
|
render(root, [c]);
|
|
|
|
// #1804
|
|
// TODO: uncomment
|
|
// o(c.dom.hasAttribute("id")).equals(false)
|
|
})
|
|
})
|
|
o.spec("customElements", function(){
|
|
|
|
o("when vnode is customElement, custom setAttribute called", function(){
|
|
|
|
var normal = [
|
|
{tag: "input", attrs: {value: "hello"}},
|
|
{tag: "input", attrs: {value: "hello"}},
|
|
{tag: "input", attrs: {value: "hello"}}
|
|
]
|
|
|
|
var custom = [
|
|
{tag: "custom-element", attrs: {custom: "x"}},
|
|
{tag: "input", attrs: {is: "something-special", custom: "x"}},
|
|
{tag: "custom-element", attrs: {is: "something-special", custom: "x"}}
|
|
]
|
|
|
|
var view = normal.concat(custom)
|
|
|
|
var f = $window.document.createElement
|
|
var spy
|
|
|
|
$window.document.createElement = function(tag, is){
|
|
var el = f(tag, is)
|
|
if(!spy){
|
|
spy = o.spy(el.setAttribute)
|
|
}
|
|
el.setAttribute = spy
|
|
|
|
return el
|
|
}
|
|
|
|
render(root, view)
|
|
|
|
o(spy.callCount).equals(custom.length)
|
|
})
|
|
|
|
})
|
|
o.spec("input readonly", function() {
|
|
o("when input readonly is true, attribute is present", function() {
|
|
var a = {tag: "input", attrs: {readonly: true}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.attributes["readonly"].value).equals("")
|
|
})
|
|
o("when input readonly is false, attribute is not present", function() {
|
|
var a = {tag: "input", attrs: {readonly: false}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.attributes["readonly"]).equals(undefined)
|
|
})
|
|
})
|
|
o.spec("input checked", function() {
|
|
o("when input checked is true, attribute is not present", function() {
|
|
var a = {tag: "input", attrs: {checked: true}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.checked).equals(true)
|
|
o(a.dom.attributes["checked"]).equals(undefined)
|
|
})
|
|
o("when input checked is false, attribute is not present", function() {
|
|
var a = {tag: "input", attrs: {checked: false}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.checked).equals(false)
|
|
o(a.dom.attributes["checked"]).equals(undefined)
|
|
})
|
|
o("after input checked is changed by 3rd party, it can still be changed by render", function() {
|
|
var a = {tag: "input", attrs: {checked: false}}
|
|
var b = {tag: "input", attrs: {checked: true}}
|
|
|
|
render(root, [a])
|
|
|
|
a.dom.checked = true //setting the javascript property makes the value no longer track the state of the attribute
|
|
a.dom.checked = false
|
|
|
|
render(root, [b])
|
|
|
|
o(a.dom.checked).equals(true)
|
|
o(a.dom.attributes["checked"]).equals(undefined)
|
|
})
|
|
})
|
|
o.spec("input.value", function() {
|
|
o("can be set as text", function() {
|
|
var a = {tag: "input", attrs: {value: "test"}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("test")
|
|
})
|
|
o("a lack of attribute removes `value`", function() {
|
|
var a = {tag: "input", attrs: {}}
|
|
var b = {tag: "input", attrs: {value: "test"}}
|
|
// var c = {tag: "input", attrs: {}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.value).equals("")
|
|
|
|
render(root, [b])
|
|
|
|
o(a.dom.value).equals("test")
|
|
|
|
// https://github.com/MithrilJS/mithril.js/issues/1804#issuecomment-304521235
|
|
// TODO: Uncomment
|
|
// render(root, [c])
|
|
|
|
// o(a.dom.value).equals("")
|
|
})
|
|
o("can be set as number", function() {
|
|
var a = {tag: "input", attrs: {value: 1}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("1")
|
|
})
|
|
o("null becomes the empty string", function() {
|
|
var a = {tag: "input", attrs: {value: null}}
|
|
var b = {tag: "input", attrs: {value: "test"}}
|
|
var c = {tag: "input", attrs: {value: null}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("")
|
|
o(a.dom.getAttribute("value")).equals(null)
|
|
|
|
render(root, [b]);
|
|
|
|
o(b.dom.value).equals("test")
|
|
o(b.dom.getAttribute("value")).equals(null)
|
|
|
|
render(root, [c]);
|
|
|
|
o(c.dom.value).equals("")
|
|
o(c.dom.getAttribute("value")).equals(null)
|
|
})
|
|
o("'' and 0 are different values", function() {
|
|
var a = {tag: "input", attrs: {value: 0}, children:[{tag:"#", children:""}]}
|
|
var b = {tag: "input", attrs: {value: ""}, children:[{tag:"#", children:""}]}
|
|
var c = {tag: "input", attrs: {value: 0}, children:[{tag:"#", children:""}]}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("0")
|
|
|
|
render(root, [b]);
|
|
|
|
o(b.dom.value).equals("")
|
|
|
|
// #1595 redux
|
|
render(root, [c]);
|
|
|
|
o(c.dom.value).equals("0")
|
|
})
|
|
o("isn't set when equivalent to the previous value and focused", function() {
|
|
var $window = domMock({spy: o.spy})
|
|
var root = $window.document.body
|
|
var render = vdom($window).render
|
|
|
|
var a = {tag: "input"}
|
|
var b = {tag: "input", attrs: {value: "1"}}
|
|
var c = {tag: "input", attrs: {value: "1"}}
|
|
var d = {tag: "input", attrs: {value: 1}}
|
|
var e = {tag: "input", attrs: {value: 2}}
|
|
|
|
render(root, [a])
|
|
var spies = $window.__getSpies(a.dom)
|
|
a.dom.focus()
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [c])
|
|
|
|
o(c.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [d])
|
|
|
|
o(d.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [e])
|
|
|
|
o(d.dom.value).equals("2")
|
|
o(spies.valueSetter.callCount).equals(2)
|
|
})
|
|
})
|
|
o.spec("input.type", function() {
|
|
o("the input.type setter is never used", function() {
|
|
var $window = domMock({spy: o.spy})
|
|
var root = $window.document.body
|
|
var render = vdom($window).render
|
|
|
|
var a = {tag: "input", attrs: {type: "radio"}}
|
|
var b = {tag: "input", attrs: {type: "text"}}
|
|
var c = {tag: "input", attrs: {}}
|
|
|
|
render(root, [a])
|
|
var spies = $window.__getSpies(a.dom)
|
|
|
|
o(spies.typeSetter.callCount).equals(0)
|
|
o(a.dom.getAttribute("type")).equals("radio")
|
|
|
|
render(root, [b])
|
|
|
|
o(spies.typeSetter.callCount).equals(0)
|
|
o(b.dom.getAttribute("type")).equals("text")
|
|
|
|
render(root, [c])
|
|
|
|
o(spies.typeSetter.callCount).equals(0)
|
|
o(c.dom.hasAttribute("type")).equals(false)
|
|
})
|
|
})
|
|
o.spec("textarea.value", function() {
|
|
o("can be removed by not passing a value", function() {
|
|
var a = {tag: "textarea", attrs: {value:"x"}}
|
|
// var b = {tag: "textarea", attrs: {}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.value).equals("x")
|
|
|
|
// https://github.com/MithrilJS/mithril.js/issues/1804#issuecomment-304521235
|
|
// TODO: Uncomment
|
|
// render(root, [b])
|
|
|
|
// o(b.dom.value).equals("")
|
|
})
|
|
o("isn't set when equivalent to the previous value and focused", function() {
|
|
var $window = domMock({spy: o.spy})
|
|
var root = $window.document.body
|
|
var render = vdom($window).render
|
|
|
|
var a = {tag: "textarea"}
|
|
var b = {tag: "textarea", attrs: {value: "1"}}
|
|
var c = {tag: "textarea", attrs: {value: "1"}}
|
|
var d = {tag: "textarea", attrs: {value: 1}}
|
|
var e = {tag: "textarea", attrs: {value: 2}}
|
|
|
|
render(root, [a])
|
|
var spies = $window.__getSpies(a.dom)
|
|
a.dom.focus()
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [c])
|
|
|
|
o(c.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [d])
|
|
|
|
o(d.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [e])
|
|
|
|
o(d.dom.value).equals("2")
|
|
o(spies.valueSetter.callCount).equals(2)
|
|
})
|
|
})
|
|
o.spec("link href", function() {
|
|
o("when link href is true, attribute is present", function() {
|
|
var a = {tag: "a", attrs: {href: true}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.attributes["href"]).notEquals(undefined)
|
|
})
|
|
o("when link href is false, attribute is not present", function() {
|
|
var a = {tag: "a", attrs: {href: false}}
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.attributes["href"]).equals(undefined)
|
|
})
|
|
})
|
|
o.spec("canvas width and height", function() {
|
|
o("uses attribute API", function() {
|
|
var canvas = {tag: "canvas", attrs: {width: "100%"}}
|
|
|
|
render(root, canvas)
|
|
|
|
o(canvas.dom.attributes["width"].value).equals("100%")
|
|
o(canvas.dom.width).equals(100)
|
|
})
|
|
})
|
|
o.spec("svg class", function() {
|
|
o("when className is specified then it should be added as a class", function() {
|
|
var a = {tag: "svg", attrs: {className: "test"}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.attributes["class"].value).equals("test")
|
|
})
|
|
})
|
|
o.spec("option.value", function() {
|
|
o("can be set as text", function() {
|
|
var a = {tag: "option", attrs: {value: "test"}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("test")
|
|
})
|
|
o("can be set as number", function() {
|
|
var a = {tag: "option", attrs: {value: 1}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("1")
|
|
})
|
|
o("null becomes 'null'", function() {
|
|
var a = {tag: "option", attrs: {value: null}}
|
|
var b = {tag: "option", attrs: {value: "test"}}
|
|
var c = {tag: "option", attrs: {value: null}}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("null")
|
|
o(a.dom.getAttribute("value")).equals("null")
|
|
|
|
render(root, [b]);
|
|
|
|
o(b.dom.value).equals("test")
|
|
o(b.dom.getAttribute("value")).equals("test")
|
|
|
|
render(root, [c]);
|
|
|
|
o(c.dom.value).equals("null")
|
|
o(c.dom.getAttribute("value")).equals("null")
|
|
})
|
|
o("'' and 0 are different values", function() {
|
|
var a = {tag: "option", attrs: {value: 0}, children:[{tag:"#", children:""}]}
|
|
var b = {tag: "option", attrs: {value: ""}, children:[{tag:"#", children:""}]}
|
|
var c = {tag: "option", attrs: {value: 0}, children:[{tag:"#", children:""}]}
|
|
|
|
render(root, [a]);
|
|
|
|
o(a.dom.value).equals("0")
|
|
|
|
render(root, [b]);
|
|
|
|
o(a.dom.value).equals("")
|
|
|
|
// #1595 redux
|
|
render(root, [c]);
|
|
|
|
o(c.dom.value).equals("0")
|
|
})
|
|
o("isn't set when equivalent to the previous value", function() {
|
|
var $window = domMock({spy: o.spy})
|
|
var root = $window.document.body
|
|
var render = vdom($window).render
|
|
|
|
var a = {tag: "option"}
|
|
var b = {tag: "option", attrs: {value: "1"}}
|
|
var c = {tag: "option", attrs: {value: "1"}}
|
|
var d = {tag: "option", attrs: {value: 1}}
|
|
var e = {tag: "option", attrs: {value: 2}}
|
|
|
|
render(root, [a])
|
|
var spies = $window.__getSpies(a.dom)
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [c])
|
|
|
|
o(c.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [d])
|
|
|
|
o(d.dom.value).equals("1")
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
|
|
render(root, [e])
|
|
|
|
o(d.dom.value).equals("2")
|
|
o(spies.valueSetter.callCount).equals(2)
|
|
})
|
|
})
|
|
o.spec("select.value", function() {
|
|
function makeSelect(value) {
|
|
var attrs = (arguments.length === 0) ? {} : {value: value}
|
|
return {tag: "select", attrs: attrs, children: [
|
|
{tag:"option", attrs: {value: "1"}},
|
|
{tag:"option", attrs: {value: "2"}},
|
|
{tag:"option", attrs: {value: "a"}},
|
|
{tag:"option", attrs: {value: "0"}},
|
|
{tag:"option", attrs: {value: ""}}
|
|
]}
|
|
}
|
|
/* FIXME
|
|
This incomplete test is meant for testing #1916.
|
|
However it cannot be completed until #1978 is addressed
|
|
which is a lack a working select.selected / option.selected
|
|
attribute. Ask isiahmeadows.
|
|
|
|
o("render select options", function() {
|
|
var select = {tag: "select", selectedIndex: 0, children: [
|
|
{tag:"option", attrs: {value: "1", selected: ""}}
|
|
]}
|
|
render(root, select)
|
|
})
|
|
*/
|
|
o("can be set as text", function() {
|
|
var a = makeSelect()
|
|
var b = makeSelect("2")
|
|
var c = makeSelect("a")
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.value).equals("1")
|
|
o(a.dom.selectedIndex).equals(0)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("2")
|
|
o(b.dom.selectedIndex).equals(1)
|
|
|
|
render(root, [c])
|
|
|
|
o(c.dom.value).equals("a")
|
|
o(c.dom.selectedIndex).equals(2)
|
|
})
|
|
o("setting null unsets the value", function() {
|
|
var a = makeSelect(null)
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.value).equals("")
|
|
o(a.dom.selectedIndex).equals(-1)
|
|
})
|
|
o("values are type converted", function() {
|
|
var a = makeSelect(1)
|
|
var b = makeSelect(2)
|
|
|
|
render(root, [a])
|
|
|
|
o(a.dom.value).equals("1")
|
|
o(a.dom.selectedIndex).equals(0)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("2")
|
|
o(b.dom.selectedIndex).equals(1)
|
|
})
|
|
o("'' and 0 are different values when focused", function() {
|
|
var a = makeSelect("")
|
|
var b = makeSelect(0)
|
|
|
|
render(root, [a])
|
|
a.dom.focus()
|
|
|
|
o(a.dom.value).equals("")
|
|
|
|
// #1595 redux
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("0")
|
|
})
|
|
o("'' and null are different values when focused", function() {
|
|
var a = makeSelect("")
|
|
var b = makeSelect(null)
|
|
var c = makeSelect("")
|
|
|
|
render(root, [a])
|
|
a.dom.focus()
|
|
|
|
o(a.dom.value).equals("")
|
|
o(a.dom.selectedIndex).equals(4)
|
|
|
|
render(root, [b])
|
|
|
|
o(b.dom.value).equals("")
|
|
o(b.dom.selectedIndex).equals(-1)
|
|
|
|
render(root, [c])
|
|
|
|
o(c.dom.value).equals("")
|
|
o(c.dom.selectedIndex).equals(4)
|
|
})
|
|
o("updates with the same value do not re-set the attribute if the select has focus", function() {
|
|
var $window = domMock({spy: o.spy})
|
|
var root = $window.document.body
|
|
var render = vdom($window).render
|
|
|
|
var a = makeSelect()
|
|
var b = makeSelect("1")
|
|
var c = makeSelect(1)
|
|
var d = makeSelect("2")
|
|
|
|
render(root, [a])
|
|
var spies = $window.__getSpies(a.dom)
|
|
a.dom.focus()
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
o(a.dom.value).equals("1")
|
|
|
|
render(root, [b])
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
o(b.dom.value).equals("1")
|
|
|
|
render(root, [c])
|
|
|
|
o(spies.valueSetter.callCount).equals(0)
|
|
o(c.dom.value).equals("1")
|
|
|
|
render(root, [d])
|
|
|
|
o(spies.valueSetter.callCount).equals(1)
|
|
o(d.dom.value).equals("2")
|
|
})
|
|
})
|
|
o.spec("contenteditable throws on untrusted children", function() {
|
|
o("including text nodes", function() {
|
|
var div = {tag: "div", attrs: {contenteditable: true}, text: ""}
|
|
var succeeded = false
|
|
|
|
try {
|
|
render(root, div)
|
|
|
|
succeeded = true
|
|
}
|
|
catch(e){/* ignore */}
|
|
|
|
o(succeeded).equals(false)
|
|
})
|
|
o("including elements", function() {
|
|
var div = {tag: "div", attrs: {contenteditable: true}, children: [{tag: "script", attrs: {src: "http://evil.com"}}]}
|
|
var succeeded = false
|
|
|
|
try {
|
|
render(root, div)
|
|
|
|
succeeded = true
|
|
}
|
|
catch(e){/* ignore */}
|
|
|
|
o(succeeded).equals(false)
|
|
})
|
|
o("tolerating empty children", function() {
|
|
var div = {tag: "div", attrs: {contenteditable: true}, children: []}
|
|
var succeeded = false
|
|
|
|
try {
|
|
render(root, div)
|
|
|
|
succeeded = true
|
|
}
|
|
catch(e){/* ignore */}
|
|
|
|
o(succeeded).equals(true)
|
|
})
|
|
o("tolerating trusted content", function() {
|
|
var div = {tag: "div", attrs: {contenteditable: true}, children: [{tag: "<", children: "<a></a>"}]}
|
|
var succeeded = false
|
|
|
|
try {
|
|
render(root, div)
|
|
|
|
succeeded = true
|
|
}
|
|
catch(e){/* ignore */}
|
|
|
|
o(succeeded).equals(true)
|
|
})
|
|
})
|
|
})
|