* De-servicify router (mostly) Still uses the redraw service, but it no longer has an intermediate service of its own. Also, did a *lot* of test deduplication in this. About 30-40% of the router service tests were already tested on the main router API instance itself. Bundle size decreased from 9560 to 9548 bytes min+gzip. * Merge `m.mount` + `m.redraw`, update router Simplifies the router and redraw mechanism, and makes it much easier to keep predictable. Bundle size down to 9433 bytes min+gzip, docs updated accordingly. * Make `mithril/render` just return the `m.render` function directly. * Deservicify `m.render`, revise `m.route` - You now have to use `mithril/render/render` directly if you want an implicit redraw function. (This will likely be going away in v3.) - Revise `m.route` to only `key` components * Add `redraw` to `m.render`, deservicify requests * Test error logging * Update docs + changelog [skip ci]
210 lines
5.7 KiB
JavaScript
210 lines
5.7 KiB
JavaScript
"use strict"
|
|
|
|
var o = require("../../ospec/ospec")
|
|
var callAsync = require("../../test-utils/callAsync")
|
|
var components = require("../../test-utils/components")
|
|
var domMock = require("../../test-utils/domMock")
|
|
var vdom = require("../../render/render")
|
|
var Promise = require("../../promise/promise")
|
|
|
|
o.spec("onbeforeremove", function() {
|
|
var $window, root, render
|
|
o.beforeEach(function() {
|
|
$window = domMock()
|
|
root = $window.document.createElement("div")
|
|
render = vdom($window)
|
|
})
|
|
|
|
o("does not call onbeforeremove when creating", function() {
|
|
var create = o.spy()
|
|
var vnode = {tag: "div", attrs: {onbeforeremove: create}}
|
|
|
|
render(root, [vnode])
|
|
|
|
o(create.callCount).equals(0)
|
|
})
|
|
o("does not call onbeforeremove when updating", function() {
|
|
var create = o.spy()
|
|
var update = o.spy()
|
|
var vnode = {tag: "div", attrs: {onbeforeremove: create}}
|
|
var updated = {tag: "div", attrs: {onbeforeremove: update}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(create.callCount).equals(0)
|
|
o(update.callCount).equals(0)
|
|
})
|
|
o("calls onbeforeremove when removing element", function(done) {
|
|
var vnode = {tag: "div", attrs: {onbeforeremove: remove}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
function remove(node) {
|
|
o(node).equals(vnode)
|
|
o(this).equals(vnode.state)
|
|
o(this != null && typeof this === "object").equals(true)
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild).equals(vnode.dom)
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(0)
|
|
|
|
done()
|
|
})
|
|
}
|
|
})
|
|
o("calls onbeforeremove when removing text", function(done) {
|
|
var vnode = {tag: "#", attrs: {onbeforeremove: remove}, children: "a"}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
function remove(node) {
|
|
o(node).equals(vnode)
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild).equals(vnode.dom)
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(0)
|
|
|
|
done()
|
|
})
|
|
}
|
|
})
|
|
o("calls onbeforeremove when removing fragment", function(done) {
|
|
var vnode = {tag: "[", attrs: {onbeforeremove: remove}, children: [{tag: "div"}]}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
function remove(node) {
|
|
o(node).equals(vnode)
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild).equals(vnode.dom)
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(0)
|
|
|
|
done()
|
|
})
|
|
}
|
|
})
|
|
o("calls onbeforeremove when removing html", function(done) {
|
|
var vnode = {tag: "<", attrs: {onbeforeremove: remove}, children: "a"}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
function remove(node) {
|
|
o(node).equals(vnode)
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild).equals(vnode.dom)
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(0)
|
|
|
|
done()
|
|
})
|
|
}
|
|
})
|
|
o("calls remove after onbeforeremove resolves", function(done) {
|
|
var spy = o.spy()
|
|
var vnode = {tag: "<", attrs: {onbeforeremove: remove, onremove: spy}, children: "a"}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
|
|
function remove(node) {
|
|
o(node).equals(vnode)
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild).equals(vnode.dom)
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(0)
|
|
o(spy.callCount).equals(1)
|
|
|
|
done()
|
|
})
|
|
}
|
|
})
|
|
o("does not set onbeforeremove as an event handler", function() {
|
|
var remove = o.spy()
|
|
var vnode = {tag: "div", attrs: {onbeforeremove: remove}, children: []}
|
|
|
|
render(root, [vnode])
|
|
|
|
o(vnode.dom.onbeforeremove).equals(undefined)
|
|
o(vnode.dom.attributes["onbeforeremove"]).equals(undefined)
|
|
})
|
|
o("does not recycle when there's an onbeforeremove", function() {
|
|
var remove = function() {}
|
|
var vnode = {tag: "div", key: 1, attrs: {onbeforeremove: remove}}
|
|
var updated = {tag: "div", key: 1, attrs: {onbeforeremove: remove}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [])
|
|
render(root, [updated])
|
|
|
|
o(vnode.dom).notEquals(updated.dom)
|
|
})
|
|
o("does not leave elements out of order during removal", function(done) {
|
|
var remove = function() {return Promise.resolve()}
|
|
var vnodes = [{tag: "div", key: 1, attrs: {onbeforeremove: remove}, text: "1"}, {tag: "div", key: 2, attrs: {onbeforeremove: remove}, text: "2"}]
|
|
var updated = {tag: "div", key: 2, attrs: {onbeforeremove: remove}, text: "2"}
|
|
|
|
render(root, vnodes)
|
|
render(root, updated)
|
|
|
|
o(root.childNodes.length).equals(2)
|
|
o(root.firstChild.firstChild.nodeValue).equals("1")
|
|
|
|
callAsync(function() {
|
|
o(root.childNodes.length).equals(1)
|
|
o(root.firstChild.firstChild.nodeValue).equals("2")
|
|
|
|
done()
|
|
})
|
|
})
|
|
components.forEach(function(cmp){
|
|
o.spec(cmp.kind, function(){
|
|
var createComponent = cmp.create
|
|
o("finalizes the remove phase asynchronously when promise is returned synchronously from both attrs- and tag.onbeforeremove", function(done) {
|
|
var onremove = o.spy()
|
|
var onbeforeremove = function(){return Promise.resolve()}
|
|
var component = createComponent({
|
|
onbeforeremove: onbeforeremove,
|
|
onremove: onremove,
|
|
view: function() {},
|
|
})
|
|
render(root, [{tag: component, attrs: {onbeforeremove: onbeforeremove, onremove: onremove}}])
|
|
render(root, [])
|
|
callAsync(function() {
|
|
o(onremove.callCount).equals(2) // once for `tag`, once for `attrs`
|
|
done()
|
|
})
|
|
})
|
|
o("awaits promise resolution before removing the node", function(done) {
|
|
var view = o.spy()
|
|
var onremove = o.spy()
|
|
var onbeforeremove = function(){return new Promise(function(resolve){callAsync(resolve)})}
|
|
var component = createComponent({
|
|
onbeforeremove: onbeforeremove,
|
|
onremove: onremove,
|
|
view: view,
|
|
})
|
|
render(root, [{tag: component}])
|
|
render(root, [])
|
|
|
|
o(onremove.callCount).equals(0)
|
|
callAsync(function(){
|
|
callAsync(function() {
|
|
o(onremove.callCount).equals(1)
|
|
done()
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|