1f4b2cf49a
* De-servicify router (mostly) Still uses the redraw service, but it no longer has an intermediate service of its own. Also, did a *lot* of test deduplication in this. About 30-40% of the router service tests were already tested on the main router API instance itself. Bundle size decreased from 9560 to 9548 bytes min+gzip. * Merge `m.mount` + `m.redraw`, update router Simplifies the router and redraw mechanism, and makes it much easier to keep predictable. Bundle size down to 9433 bytes min+gzip, docs updated accordingly. * Make `mithril/render` just return the `m.render` function directly. * Deservicify `m.render`, revise `m.route` - You now have to use `mithril/render/render` directly if you want an implicit redraw function. (This will likely be going away in v3.) - Revise `m.route` to only `key` components * Add `redraw` to `m.render`, deservicify requests * Test error logging * Update docs + changelog [skip ci]
327 lines
9.1 KiB
JavaScript
327 lines
9.1 KiB
JavaScript
"use strict"
|
|
|
|
var o = require("../../ospec/ospec")
|
|
var domMock = require("../../test-utils/domMock")
|
|
var vdom = require("../../render/render")
|
|
|
|
o.spec("updateElement", function() {
|
|
var $window, root, render
|
|
o.beforeEach(function() {
|
|
$window = domMock()
|
|
root = $window.document.createElement("div")
|
|
render = vdom($window)
|
|
})
|
|
|
|
o("updates attr", function() {
|
|
var vnode = {tag: "a", attrs: {id: "b"}}
|
|
var updated = {tag: "a", attrs: {id: "c"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(vnode.dom)
|
|
o(updated.dom).equals(root.firstChild)
|
|
o(updated.dom.attributes["id"].value).equals("c")
|
|
})
|
|
o("adds attr", function() {
|
|
var vnode = {tag: "a", attrs: {id: "b"}}
|
|
var updated = {tag: "a", attrs: {id: "c", title: "d"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(vnode.dom)
|
|
o(updated.dom).equals(root.firstChild)
|
|
o(updated.dom.attributes["title"].value).equals("d")
|
|
})
|
|
o("adds attr from empty attrs", function() {
|
|
var vnode = {tag: "a"}
|
|
var updated = {tag: "a", attrs: {title: "d"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(vnode.dom)
|
|
o(updated.dom).equals(root.firstChild)
|
|
o(updated.dom.attributes["title"].value).equals("d")
|
|
})
|
|
o("removes attr", function() {
|
|
var vnode = {tag: "a", attrs: {id: "b", title: "d"}}
|
|
var updated = {tag: "a", attrs: {id: "c"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(vnode.dom)
|
|
o(updated.dom).equals(root.firstChild)
|
|
o("title" in updated.dom.attributes).equals(false)
|
|
})
|
|
o("removes class", function() {
|
|
var vnode = {tag: "a", attrs: {id: "b", className: "d"}}
|
|
var updated = {tag: "a", attrs: {id: "c"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(vnode.dom)
|
|
o(updated.dom).equals(root.firstChild)
|
|
o("class" in updated.dom.attributes).equals(false)
|
|
})
|
|
o("creates style object", function() {
|
|
var vnode = {tag: "a", attrs: {}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "green"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("creates style string", function() {
|
|
var vnode = {tag: "a", attrs: {}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:green"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("updates style from object to object", function() {
|
|
var vnode = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "green"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("updates style from object to string", function() {
|
|
var vnode = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:green;"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("handles noop style change when style is string", function() {
|
|
var vnode = {tag: "a", attrs: {style: "background-color:green;"}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:green;"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("handles noop style change when style is object", function() {
|
|
var vnode = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("red")
|
|
})
|
|
o("updates style from string to object", function() {
|
|
var vnode = {tag: "a", attrs: {style: "background-color:red;"}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "green"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("updates style from string to string", function() {
|
|
var vnode = {tag: "a", attrs: {style: "background-color:red;"}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:green;"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("green")
|
|
})
|
|
o("removes style from object to object", function() {
|
|
var vnode = {tag: "a", attrs: {style: {backgroundColor: "red", border: "1px solid red"}}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("red")
|
|
o(updated.dom.style.border).equals("")
|
|
})
|
|
o("removes style from string to object", function() {
|
|
var vnode = {tag: "a", attrs: {style: "background-color:red;border:1px solid red"}}
|
|
var updated = {tag: "a", attrs: {style: {backgroundColor: "red"}}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("red")
|
|
o(updated.dom.style.border).notEquals("1px solid red")
|
|
})
|
|
o("removes style from object to string", function() {
|
|
var vnode = {tag: "a", attrs: {style: {backgroundColor: "red", border: "1px solid red"}}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:red"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("red")
|
|
o(updated.dom.style.border).equals("")
|
|
})
|
|
o("removes style from string to string", function() {
|
|
var vnode = {tag: "a", attrs: {style: "background-color:red;border:1px solid red"}}
|
|
var updated = {tag: "a", attrs: {style: "background-color:red"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.backgroundColor).equals("red")
|
|
o(updated.dom.style.border).equals("")
|
|
})
|
|
o("does not re-render element styles for equivalent style objects", function() {
|
|
var style = {color: "gold"}
|
|
var vnode = {tag: "a", attrs: {style: style}}
|
|
|
|
render(root, [vnode])
|
|
|
|
root.firstChild.style.color = "red"
|
|
style = {color: "gold"}
|
|
var updated = {tag: "a", attrs: {style: style}}
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.style.color).equals("red")
|
|
})
|
|
o("setting style to `null` removes all styles", function() {
|
|
var vnode = {"tag": "p", attrs: {style: "background-color: red"}}
|
|
var updated = {"tag": "p", attrs: {style: null}}
|
|
|
|
render(root, [vnode])
|
|
|
|
o("style" in vnode.dom.attributes).equals(true)
|
|
o(vnode.dom.attributes.style.value).equals("background-color: red;")
|
|
|
|
render(root, [updated])
|
|
|
|
//browsers disagree here
|
|
try {
|
|
|
|
o(updated.dom.attributes.style.value).equals("")
|
|
|
|
} catch (e) {
|
|
|
|
o("style" in updated.dom.attributes).equals(false)
|
|
|
|
}
|
|
})
|
|
o("setting style to `undefined` removes all styles", function() {
|
|
var vnode = {"tag": "p", attrs: {style: "background-color: red"}}
|
|
var updated = {"tag": "p", attrs: {style: undefined}}
|
|
|
|
render(root, [vnode])
|
|
|
|
o("style" in vnode.dom.attributes).equals(true)
|
|
o(vnode.dom.attributes.style.value).equals("background-color: red;")
|
|
|
|
render(root, [updated])
|
|
|
|
//browsers disagree here
|
|
try {
|
|
|
|
o(updated.dom.attributes.style.value).equals("")
|
|
|
|
} catch (e) {
|
|
|
|
o("style" in updated.dom.attributes).equals(false)
|
|
|
|
}
|
|
})
|
|
o("not setting style removes all styles", function() {
|
|
var vnode = {"tag": "p", attrs: {style: "background-color: red"}}
|
|
var updated = {"tag": "p", attrs: {}}
|
|
|
|
render(root, [vnode])
|
|
|
|
o("style" in vnode.dom.attributes).equals(true)
|
|
o(vnode.dom.attributes.style.value).equals("background-color: red;")
|
|
|
|
render(root, [updated])
|
|
|
|
//browsers disagree here
|
|
try {
|
|
|
|
o(updated.dom.attributes.style.value).equals("")
|
|
|
|
} catch (e) {
|
|
|
|
o("style" in updated.dom.attributes).equals(false)
|
|
|
|
}
|
|
})
|
|
o("replaces el", function() {
|
|
var vnode = {tag: "a"}
|
|
var updated = {tag: "b"}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom).equals(root.firstChild)
|
|
o(updated.dom.nodeName).equals("B")
|
|
})
|
|
o("updates svg class", function() {
|
|
var vnode = {tag: "svg", attrs: {className: "a"}}
|
|
var updated = {tag: "svg", attrs: {className: "b"}}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.attributes["class"].value).equals("b")
|
|
})
|
|
o("updates svg child", function() {
|
|
var vnode = {tag: "svg", children: [{
|
|
tag: "circle"
|
|
}]}
|
|
var updated = {tag: "svg", children: [{
|
|
tag: "line"
|
|
}]}
|
|
|
|
render(root, [vnode])
|
|
render(root, [updated])
|
|
|
|
o(updated.dom.firstChild.namespaceURI).equals("http://www.w3.org/2000/svg")
|
|
})
|
|
o("doesn't restore since we're not recycling", function() {
|
|
var vnode = {tag: "div", key: 1}
|
|
var updated = {tag: "div", key: 2}
|
|
|
|
render(root, [vnode])
|
|
var a = vnode.dom
|
|
|
|
render(root, [updated])
|
|
|
|
render(root, [vnode])
|
|
var c = vnode.dom
|
|
|
|
o(root.childNodes.length).equals(1)
|
|
o(a).notEquals(c) // this used to be a recycling pool test
|
|
})
|
|
o("doesn't restore since we're not recycling (via map)", function() {
|
|
var a = {tag: "div", key: 1}
|
|
var b = {tag: "div", key: 2}
|
|
var c = {tag: "div", key: 3}
|
|
var d = {tag: "div", key: 4}
|
|
var e = {tag: "div", key: 5}
|
|
var f = {tag: "div", key: 6}
|
|
|
|
render(root, [a, b, c])
|
|
var x = root.childNodes[1]
|
|
|
|
render(root, [d])
|
|
|
|
render(root, [e, b, f])
|
|
var y = root.childNodes[1]
|
|
|
|
o(root.childNodes.length).equals(3)
|
|
o(x).notEquals(y) // this used to be a recycling pool test
|
|
})
|
|
})
|