VNDB fork of mithril.js
Find a file
Isiah Meadows 58f1c74394
Streamline route/request path handling and split params + body in requests (#2361)
Fixes #2360
Fixes #1138
Fixes #1788 a little less hackishly
Probably fixes a few other issues I'm not aware of.

This more or less goes with @lhorie's comment here, just with a minor name
change from `query` to `params`:

https://github.com/MithrilJS/mithril.js/issues/1138#issuecomment-231363395

Specifically, here's what this patch entails:

- I changed `data` and `useBody` to `params` and `body` in `m.request`.
  Migration is trivial: just use `params` or `body` depending on which you
  intend to send. Most servers do actually care where the data goes, so you can
  generally pretty easily translate this accordingly. If you *really* need the
  old behavior, pass the old value in `params` and if `method === "GET"` or
  `method === "TRACE"`, also in `body`.
- I opened up all methods to have request bodies.
- I fixed `m.parseQueryString` to prefer later values over earlier values and
  to ensure that objects and arrays are persisted across both hash and query
  param parsing. That method also accepts an existing key/value map to append
  to, to simplify deduplication.
- I normalized path interpolation to be identical between routes and requests.
- I no longer include interpolated values in query strings. If you need to
  duplicate values again, rename the interpolation to be a distinct property
  and pass the value you want to duplicate as it.
- I converted `m.route` to use pre-compiled routes instead of its existing
  system of dynamic runtime checking. This shouldn't have a major effect on
  performance short-term, but it'll ease the migration to built-in userland
  components and make it a little easier to reconcile. It'll also come handy
  for large numbers of routes.
- I added support for matching routes like `"/:file.:ext"` or
  `"/:lang-:region"`, giving each defined semantics.
- I added support for matching against routes with static query strings, such
  as `"/edit?type=image": { ... }`.
- I'm throwing a few new informative errors.
- And I've updated the docs accordingly.

I also made a few drive-by edits:

- I fixed a bug in the `Stream.HALT` warning where it warned all but the first
  usage when the intent was to warn only on first use.
- Some of the tests were erroneously using `Stream.HALT` when they should've
  been using `Stream.SKIP`. I've fixed the tests to only test that
  `Stream.HALT === Stream.SKIP` and that it only warns on first use.
- The `m.request` and `m.jsonp` docs signatures were improved to more clearly
  explain how `m.request(url, options?)` and `m.jsonp(url, options?)` translate
  to `m.request(options)` and `m.jsonp(options)` respectively.

-----

There is some justification to these changes:

- In general, it matters surprisingly more than you would expect how things
  translate to HTTP requests. So the comment there suggesting a thing that
  papers over the difference has led to plenty of confusion in both Gitter and
  in GitHub issues.

- A lot of servers expect a GET with a body and no parameters, and leaving
  `m.request` open to working with that makes it much more flexible.

- Sometimes, servers expect a POST with query parameters *instead* of a JSON
  object. I've seen this quite a bit, even with more popular REST APIs like
  Stack Overflow's.

- I've encountered a few servers that expect both parameters and a body, each
  with distinct semantic meaning, so the separation makes it much easier to
  translate into a request.

- Most of the time, path segments are treated individually, and URL-escaping
  the contents is much less error-prone. It also avoids being potentially
  lossy, and when the variable in question isn't trusted, escaping the path
  segment enables you to pass it through the URL and not risk being redirected
  to unexpected locations, avoiding some risks of vulnerabilities and client
  side crashes.

If you really don't care how the template and parameters translate to an
eventual URL, just pass the same object for the `params` and `body` and use
`:param...` for each segment. Either way, the more explicit nature should help
a lot in making the intent clearer, whether you care or not.
2019-05-29 09:28:40 -04:00
.github Create an Issues Submission Page Enhancement (#2271) 2018-11-28 14:47:27 -05:00
api Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
bundler Fix some linter issues, update ESLint (#2318) 2018-11-30 03:11:07 -05:00
docs Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
examples Fix mixed content error. (#2383) 2019-03-02 02:22:39 -05:00
module Officially drop IE9-10 support, pull out our hacks (#2296) 2018-11-27 18:04:15 -05:00
ospec Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
pathname Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
performance [performance] use individual files rather than the build, revamp the attrs code to reduce variance, reset the scratch pad more reliably 2018-06-07 18:09:38 +02:00
promise Merge branch 'next' 2018-10-25 14:23:33 -04:00
querystring Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
render Handle [ fragment selector. Fixes #2349 (#2352) 2019-01-07 04:56:09 -05:00
request Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
router Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
stream Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
test-utils Fix m.request/m.jsonp to not mutate arguments, simplify code (#2288) 2018-11-28 20:10:46 -05:00
tests Remove m.prop + m.withAttr (#2317) 2018-11-30 20:41:24 -05:00
.deploy.enc Swap out keys so they use mine (#2393) 2019-03-09 02:04:30 -05:00
.editorconfig clean up repo 2017-01-30 11:18:47 -05:00
.eslintignore Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
.eslintrc.js Revert eslintrc change, return Promise instead of using async/await 2017-11-29 17:03:07 +01:00
.gitattributes Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
.gitignore "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
.npmignore Update package lockfile and danger/lint-staged 2017-08-25 02:59:38 -04:00
.travis.yml Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
browser.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
hyperscript.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
index.js Streamline route/request path handling and split params + body in requests (#2361) 2019-05-29 09:28:40 -04:00
LICENSE docs: Adding license file. (#1583) 2017-02-01 09:25:00 -08:00
mithril.js Bundled output for commit a9172f1129 [skip ci] 2019-02-07 10:14:46 +00:00
mithril.min.js Bundled output for commit a9172f1129 [skip ci] 2019-02-07 10:14:46 +00:00
mount.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
package-lock.json Bundled output for commit 0707de5867 [skip ci] 2019-03-09 07:06:45 +00:00
package.json Drop ESM support (#2366) 2019-05-29 09:24:10 -04:00
README.md standardize cdn links in docs (#2416) 2019-05-27 11:58:11 -04:00
redraw.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
render.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
request.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
route.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00
stream.js "use strict" and other linty fixes 2017-03-03 18:24:38 -05:00

mithril.js NPM Version NPM License NPM Downloads Donate at OpenCollective

Build Status Gitter

What is Mithril?

A modern client-side Javascript framework for building Single Page Applications. It's small (8.88 KB gzipped), fast and provides routing and XHR utilities out of the box.

Mithril is used by companies like Vimeo and Nike, and open source platforms like Lichess 👍.

Mithril supports IE11, Firefox ESR, and the last two versions of Firefox, Edge, Safari, and Chrome. No polyfills required. 👌

Installation

CDN

<script src="https://unpkg.com/mithril@next/mithril.js"></script>
<!-- or -->
<script src="https://cdn.jsdelivr.net/npm/mithril@next/mithril.js"></script>

npm

# For the most recent stable version
$ npm install mithril --save
# For the most recent unstable version
$ npm install mithril@next --save

The "Getting started" guide is a good place to start learning how to use mithril.

Documentation

Documentation lives on mithril.js.org.

You may be interested in the API Docs, a Simple Application, or perhaps some Examples.

Getting Help

Mithril has an active & welcoming community on Gitter, or feel free to ask questions on Stack Overflow using the mithril.js tag.

Contributing

There's a Contributing FAQ on the mithril site that hopefully helps, but if not definitely hop into the Gitter Room and ask away!


Thanks for reading!

🎁