85bfd0f77d
* Clarify pathname docs, follow spec with fragments - Valid URLs must not contain a `#` within its fragment. https://github.com/MithrilJS/mithril.js/issues/2445 - Our docs were a little confusing and misleading - `m.pathname` isn't aware of URLs, just path names. - Removed the relevant extension to `m.parseQueryString` required to support the hash parsing extension. Now we just shave it off and ignore it. - Fix support for arbitrary prefixes, so prefixes like `?#` are handled correctly. - Add a bunch of tests to cover various areas of confusion and unusual edge cases. * Update with PR [skip ci]
252 lines
7.3 KiB
JavaScript
252 lines
7.3 KiB
JavaScript
"use strict"
|
|
|
|
var o = require("../../ospec/ospec")
|
|
var callAsync = require("../../test-utils/callAsync")
|
|
var pushStateMock = require("../../test-utils/pushStateMock")
|
|
var Router = require("../../router/router")
|
|
|
|
o.spec("Router.defineRoutes", function() {
|
|
void [{protocol: "http:", hostname: "localhost"}, {protocol: "file:", hostname: "/"}].forEach(function(env) {
|
|
void ["#", "?", "", "#!", "?!", "/foo", "?#", "##"].forEach(function(prefix) {
|
|
o.spec("using prefix `" + prefix + "` starting on " + env.protocol + "//" + env.hostname, function() {
|
|
var $window, router, onRouteChange, onFail
|
|
|
|
o.beforeEach(function() {
|
|
$window = pushStateMock(env)
|
|
router = new Router($window)
|
|
router.prefix = prefix
|
|
onRouteChange = o.spy()
|
|
onFail = o.spy()
|
|
})
|
|
|
|
o("calls onRouteChange on init", function(done) {
|
|
$window.location.href = prefix + "/a"
|
|
router.defineRoutes({"/a": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("resolves to route", function(done) {
|
|
$window.location.href = prefix + "/test"
|
|
router.defineRoutes({"/test": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {}, "/test", "/test"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("resolves to route w/ escaped unicode", function(done) {
|
|
$window.location.href = prefix + "/%C3%B6?%C3%B6=%C3%B6"
|
|
router.defineRoutes({"/ö": {data: 2}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 2}, {"ö": "ö"}, "/ö?ö=ö", "/ö"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("resolves to route w/ unicode", function(done) {
|
|
$window.location.href = prefix + "/ö?ö=ö"
|
|
router.defineRoutes({"/ö": {data: 2}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 2}, {"ö": "ö"}, "/ö?ö=ö", "/ö"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("resolves to route on fallback mode", function(done) {
|
|
$window.location.href = "file://" + prefix + "/test"
|
|
|
|
router = new Router($window)
|
|
router.prefix = prefix
|
|
|
|
router.defineRoutes({"/test": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {}, "/test", "/test"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles parameterized route", function(done) {
|
|
$window.location.href = prefix + "/test/x"
|
|
router.defineRoutes({"/test/:a": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {a: "x"}, "/test/x", "/test/:a"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles multi-parameterized route", function(done) {
|
|
$window.location.href = prefix + "/test/x/y"
|
|
router.defineRoutes({"/test/:a/:b": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {a: "x", b: "y"}, "/test/x/y", "/test/:a/:b"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles rest parameterized route", function(done) {
|
|
$window.location.href = prefix + "/test/x/y"
|
|
router.defineRoutes({"/test/:a...": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {a: "x/y"}, "/test/x/y", "/test/:a..."])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles route with search", function(done) {
|
|
$window.location.href = prefix + "/test?a=b&c=d"
|
|
router.defineRoutes({"/test": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {a: "b", c: "d"}, "/test?a=b&c=d", "/test"])
|
|
o(onFail.callCount).equals(0)
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("calls reject", function(done) {
|
|
$window.location.href = prefix + "/test"
|
|
router.defineRoutes({"/other": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onFail.callCount).equals(1)
|
|
o(onFail.args).deepEquals(["/test", {}])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles out of order routes", function(done) {
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes({"/z/y/x": {data: 1}, "/:a...": {data: 2}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {}, "/z/y/x", "/z/y/x"])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles reverse out of order routes", function(done) {
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes({"/:a...": {data: 2}, "/z/y/x": {data: 1}}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 2}, {a: "z/y/x"}, "/z/y/x", "/:a..."])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles dynamically added out of order routes", function(done) {
|
|
var routes = {}
|
|
routes["/z/y/x"] = {data: 1}
|
|
routes["/:a..."] = {data: 2}
|
|
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes(routes, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {}, "/z/y/x", "/z/y/x"])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles reversed dynamically added out of order routes", function(done) {
|
|
var routes = {}
|
|
routes["/:a..."] = {data: 2}
|
|
routes["/z/y/x"] = {data: 1}
|
|
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes(routes, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 2}, {a: "z/y/x"}, "/z/y/x", "/:a..."])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles mixed out of order routes", function(done) {
|
|
var routes = {"/z/y/x": {data: 1}}
|
|
routes["/:a..."] = {data: 2}
|
|
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes(routes, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 1}, {}, "/z/y/x", "/z/y/x"])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles reverse mixed out of order routes", function(done) {
|
|
var routes = {"/:a...": {data: 2}}
|
|
routes["/z/y/x"] = {data: 12}
|
|
|
|
$window.location.href = prefix + "/z/y/x"
|
|
router.defineRoutes(routes, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
o(onRouteChange.args).deepEquals([{data: 2}, {a: "z/y/x"}, "/z/y/x", "/:a..."])
|
|
|
|
done()
|
|
})
|
|
})
|
|
|
|
o("handles non-ascii routes", function(done) {
|
|
$window.location.href = prefix + "/ö"
|
|
router.defineRoutes({"/ö": "aaa"}, onRouteChange, onFail)
|
|
|
|
callAsync(function() {
|
|
o(onRouteChange.callCount).equals(1)
|
|
|
|
done()
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|