vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

vnode.attrs is never null

Browse source
This commit is contained in:
Barney Carroll 2021-05-02 15:09:47 +01:00 • committed by Stephan Hoyer
parent e4c6621ba8
commit f9e51636d8
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
render/hyperscript.js
View file

@ -36,7 +36,7 @@ function execSelector(state, vnode) {
var className = hasClass ? attrs.class : attrs.className var className = hasClass ? attrs.class : attrs.className
vnode.tag = state.tag vnode.tag = state.tag
vnode.attrs = null vnode.attrs = {}
if (!isEmpty(state.attrs) && !isEmpty(attrs)) { if (!isEmpty(state.attrs) && !isEmpty(attrs)) {
var newAttrs = {} var newAttrs = {}

10
render/tests/test-hyperscript.js
View file

@ -271,7 +271,7 @@ o.spec("hyperscript", function() {
var vnode = m("div", {key:"a"}) var vnode = m("div", {key:"a"})
o(vnode.tag).equals("div") o(vnode.tag).equals("div")
o(vnode.attrs).equals(null) o(vnode.attrs).deepEquals({})
o(vnode.key).equals("a") o(vnode.key).equals("a")
}) })
o("handles many attrs", function() { o("handles many attrs", function() {
@ -343,7 +343,7 @@ o.spec("hyperscript", function() {
var vnode = m("custom-element", {key:"a"}) var vnode = m("custom-element", {key:"a"})
o(vnode.tag).equals("custom-element") o(vnode.tag).equals("custom-element")
o(vnode.attrs).equals(null) o(vnode.attrs).deepEquals({})
o(vnode.key).equals("a") o(vnode.key).equals("a")
}) })
o("handles many attrs", function() { o("handles many attrs", function() {
@ -551,20 +551,20 @@ o.spec("hyperscript", function() {
o("handles children without attr", function() { o("handles children without attr", function() {
var vnode = m("div", [m("i"), m("s")]) var vnode = m("div", [m("i"), m("s")])
o(vnode.attrs).equals(null) o(vnode.attrs).deepEquals({})
o(vnode.children[0].tag).equals("i") o(vnode.children[0].tag).equals("i")
o(vnode.children[1].tag).equals("s") o(vnode.children[1].tag).equals("s")
}) })
o("handles child without attr unwrapped", function() { o("handles child without attr unwrapped", function() {
var vnode = m("div", m("i")) var vnode = m("div", m("i"))
o(vnode.attrs).equals(null) o(vnode.attrs).deepEquals({})
o(vnode.children[0].tag).equals("i") o(vnode.children[0].tag).equals("i")
}) })
o("handles children without attr unwrapped", function() { o("handles children without attr unwrapped", function() {
var vnode = m("div", m("i"), m("s")) var vnode = m("div", m("i"), m("s"))
o(vnode.attrs).equals(null) o(vnode.attrs).deepEquals({})
o(vnode.children[0].tag).equals("i") o(vnode.children[0].tag).equals("i")
o(vnode.children[1].tag).equals("s") o(vnode.children[1].tag).equals("s")
}) })