Commit graph

1487 commits

Author SHA1 Message Date
Leo Horie
1ac540cf80 Merge pull request #1160 from kronion/editorconfig-specify-tab-width
Specify tab width in editorconfig
2016-07-18 09:43:32 -04:00
Collin Stedman
4616f2bab0 Specify tab width in editorconfig 2016-07-18 09:31:04 -04:00
Leo Horie
0039a0b4a5 Merge pull request #1144 from ludbek/proper.component
proper component check at m()
2016-07-11 15:52:52 -04:00
ludbek
e46f8d5881 fixed syntax error 2016-07-11 20:56:39 +05:45
ludbek
cb64be965b removed stupid test 2016-07-11 20:34:03 +05:45
ludbek
8d14e811f9 proper component check at m() 2016-07-11 10:55:30 +05:45
Isiah Meadows
03c6188989 Merge pull request #1137 from nurtom/patch-1
Tests for issue #1124/#1125
2016-07-06 18:55:23 -04:00
Thomas Erfurth
3a9a271765 Merge remote-tracking branch 'origin/patch-1' into patch-1
# Conflicts:
#	mithril.js
2016-07-06 16:05:40 +02:00
Thomas Erfurth
d6f7653e31 Added tests for history modification when switching routes with parameters (#1125) 2016-07-06 16:00:39 +02:00
darda
c17ea5bbc8 Push route to history stack, when using parameters
Bugfix for issue #1124
The condition has been changed, which is deciding to push the a route to history stack.
I think, it is necessary to compare the old route with the current route, instead of old route with root (without parameters).
2016-07-06 16:00:39 +02:00
Thomas Erfurth
d327c92f0a Added tests for history modification when switching routes with parameters (#1125) 2016-07-06 10:54:46 +02:00
Leo Horie
b848655d8b Merge pull request #1131 from 2is10/route
Fixing m.route() after a canceled navigation (#1126)
2016-06-30 08:32:16 -04:00
Jared Jacobs
e9e2a45caa Fixing m.route() after a canceled navigation (#1126) 2016-06-29 22:48:45 -07:00
Leo Horie
2173d8c0e3 Merge pull request #1129 from 2is10/contributing
Updating the links to known failing tests (now just one)
2016-06-29 18:45:18 -04:00
Jared Jacobs
d59341ed06 Updating the links to known failing tests (now just one) 2016-06-29 15:34:41 -07:00
darda
753944efe8 Push route to history stack, when using parameters
Bugfix for issue #1124
The condition has been changed, which is deciding to push the a route to history stack.
I think, it is necessary to compare the old route with the current route, instead of old route with root (without parameters).
2016-06-23 08:49:18 +02:00
Leo Horie
015f127563 Merge pull request #1119 from futurist/next
FIX: ES3 props keyword bug in IE8; eslint errors
2016-06-20 09:50:10 -04:00
1111hui
2c3d3e5df0 cleanup and apply editorconfig 2016-06-20 16:15:59 +08:00
1111hui
8550501fb2 FIX: ES3 props keyword bug in IE8; eslint errors 2016-06-20 15:41:50 +08:00
Isiah Meadows
0294293f82 Merge pull request #1117 from epidemian/remove-peristent-unloaders
Remove unloaders when root element is removed
2016-06-18 15:35:18 -04:00
Demian Ferreiro
3e51c8c2ff Remove unloaders when root element is removed
When a controller calls preventDefault on its onunload method, it prevents the current root element from being unmounted via a route change. But it does not prevent it from being unmounted via m.mount(root, null). In that case, the root element is unmounted, but any unloaders that it had keep hanging on the `unloaders` array, and that prevented any future m.mount(root, component) calls from succeeding. This is what was happening on the pending route() tests.

The fix is pretty simple: just reset the `unloaders` array when removing the root element, just like it's done when no unloader calls preventDefault.

Also, 2 of the 4 pending tests were removed because they were identical to the other 2.
2016-06-18 07:41:49 -03:00
Pat Cavit
73dbc149b5 Merge pull request #1111 from djtango/patch-1
Update mithril.md
2016-06-17 09:10:12 -07:00
Deon Tan
6ffeeaa19d Update mithril.md
Should component be MyComponent?
2016-06-17 16:13:02 +01:00
Isiah Meadows
5cff2945b2 Merge pull request #1110 from isiahmeadows/next
Add definition file to npm
2016-06-17 06:14:55 -04:00
impinball
cb10456bbe Add definition file to npm [ci skip] 2016-06-17 06:09:04 -04:00
Leo Horie
c55917d21a Merge pull request #1106 from epidemian/fix-1091
Fix #1091 Value on select tag not set when options are changed
2016-06-13 11:13:32 -04:00
Demian Ferreiro
f3dd4fce7d Fix #1091 set correct select value when options change
Always consider the edge case of setting a <select> value when building an object. When a <select> node is reused, its option children can change, so its value attribute has to be re-assigned after its children have been recreated/updated.
2016-06-13 03:55:57 -03:00
Demian Ferreiro
1b36f2b720 Add test for select value render edge case 2016-06-13 02:38:51 -03:00
Leo Horie
8faab54c4c Merge pull request #1103 from brlewis/next
Render booleans as empty strings
2016-06-10 15:26:33 -04:00
Bruce Lewis
c98f663653 Render booleans as empty strings 2016-06-10 11:00:56 -04:00
Leo Horie
6f865f6abf duplicate test fix into old test suite 2016-06-10 10:30:31 -04:00
Leo Horie
8ee75924c8 issue template 2016-06-06 09:53:37 -04:00
Leo Horie
9f91858843 Merge remote-tracking branch 'origin/next' into next 2016-06-06 09:22:20 -04:00
Leo Horie
3cf16631a0 fix valueless attributes #1093 2016-06-06 09:21:58 -04:00
Leo Horie
ece9376711 Merge pull request #1094 from syaiful6/select2-docs
update integration docs
2016-06-05 11:21:06 -04:00
Syaiful Bahri
52b0918297 update integration docs
correct the code example to avoid infinite loop

the infinite loop occure because the code example also
update the value on change handler. issue #954.
prove https://jsfiddle.net/syaiful6/kps3gabo/
2016-06-05 12:02:55 +07:00
Leo Horie
2289061f90 fix doc 2016-06-03 16:53:24 -04:00
Leo Horie
474c43e433 update style if it's mutated object 2016-06-02 18:47:41 -04:00
Leo Horie
e48265dec8 Merge remote-tracking branch 'origin/next' into next 2016-06-01 15:42:32 -04:00
Leo Horie
80349b3c74 #1080 parse pattern attribute correctly 2016-06-01 15:42:08 -04:00
Leo Horie
2f562505c3 Merge pull request #1081 from virtyaluk/patch-1
Fixes js.org badge link.
2016-05-31 10:01:07 -04:00
Bohdan Shtepan
3f4df52d6e Fixes js.org badge link.
I believe js.org badge goes to the wrong location. So I changed it from *js.org* to *mithril.js.org/*.
2016-05-30 20:54:18 +03:00
Leo Horie
129e0baf43 Merge pull request #1078 from epidemian/patch-2
Update mithril.request.md
2016-05-27 10:28:35 -04:00
Demian Ferreiro
20dfbbadc6 Update mithril.request.md
Add call to promise returned by m.request(). Otherwise the value of `ctrl.user` will always be truthy.
2016-05-27 11:08:47 -03:00
Leo Horie
b128fd8232 don't shortcircuit promise check for objects 2016-05-26 11:45:48 -04:00
Leo Horie
ce748f9f71 check for existence of Promise before doing check against it 2016-05-26 11:30:27 -04:00
Leo Horie
0ad6749f87 callbackName 2016-05-26 11:19:39 -04:00
Leo Horie
bdd65b3b86 Merge remote-tracking branch 'origin/next' into next 2016-05-26 11:04:51 -04:00
Leo Horie
bf85b7a530 #1076 absorb native promise in m.prop 2016-05-26 11:04:04 -04:00
Leo Horie
42b21a5950 Merge pull request #1063 from il-juggler/patch-1
Update mithril.request.md
2016-05-20 18:12:51 -04:00